Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit raw collection label for L1TRawToDigi (10_3_X) #25194

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

mandrenguyen
Copy link
Contributor

Backport of #25193

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 10, 2018

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_10_3_X.

It involves the following packages:

EventFilter/L1TRawToDigi

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor Author

@bi-ran @icali

@thomreis
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31618/console Started: 2018/11/13 08:53

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25194/31618/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3163099
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162901
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

@rekovic @thomreis this looks to work in master. Do you have any doubt about merging it?

1 similar comment
@fabiocos
Copy link
Contributor

@rekovic @thomreis this looks to work in master. Do you have any doubt about merging it?

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@rekovic @thomreis please sign this for reference, or comment for possible further updates

@cmsbuild cmsbuild merged commit 3517c64 into cms-sw:CMSSW_10_3_X Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants