Add explicit raw collection label for L1TRawToDigi

[mandrenguyen]

The --repacked command tells the driver to grab raw data with the remapped label.
It does this by invoking the following:
from Configuration.Applications.ConfigBuilder import MassReplaceInputTag
MassReplaceInputTag(process, new="rawDataMapperByLabel", old="rawDataCollector")

The problem is that this doesn't seem to get picked up when this is set in the fillDescriptions, as in EventFilter/L1TRawToDigi/plugins/L1TRawToDigi.cc

This PR makes the InputTag explicit, such that it's picked up by MassReplaceInputTag

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25193/7202

[cmsbuild]

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

EventFilter/L1TRawToDigi

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test workflow 140.56,140.57

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31588/console Started: 2018/11/11 10:42

[cmsbuild]

+1
Tested at: 09ff73e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25193/31588/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25193/31588/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013827
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013629
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

this workaround looks to solve the problem #25177 . @Dr15Jones is this supposed to be the expected behaviour of https://cmssdt.cern.ch/lxr/source/FWCore/ParameterSet/python/MassReplace.py ?
I see that the InputTag parameter is set as tracked in the fillDescription function of L1TRawToDigi but then it is never mentioned in all the cfi files built using this module in the python area. I would like to understand whether this is to be considered as a bug (which is fixed by this PR), regadless of the behaviour of MassReplace....

[fabiocos]

@rekovic @thomreis please see this fix, at present L1T is not correctly working for HI workflows

[Dr15Jones]

@fabiocos the python code can't see stuff that is only in C++. That being said, it actually isn't that the value is defined in fillDescription that causes the problem. The problem is there is a hand written cfi.py file for the module which takes precedence over the cfi.py file that fillDescription generates. The auto generated cfi.py would have had the InputLabel parameter exposed to python and therefore would have been changed by the call to MassReplace.

[fabiocos]

@Dr15Jones thank you for confirming, the problem is in the incomplete structure of the python cfi stored in the repository

@rekovic @thomreis I will integrate this PR to get the fix. Please sign it in case for reference

[fabiocos]

+1

[fabiocos]

merge

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.