CUDA Vector for easier pushback #7
Conversation
- remove log files - rename CUDA plugins to avoid conflict with standard ones - recover non-GPU code
- fill siPixel digi collection - other changes - add DQM validation - fix column binning
- changes for validation - add and unpack errors - add module to unpacking and bad rocs - map fixes
- remove `static` variables - comment out the debug code - general clean up
…eInPath Backport, Modify FileInPath to not lookup file in edmWriteConfigs
Restoring egamma DQM sequence for allForPrompt (100X)
…ix4-100X Fixes for conddb tools
Make calls to TH2F::Projection thread-safe for 10_0
Thread safe pileup histogram for mixing
Adding an accessor for groomed jet mass in 10.0.x
Fix compression level in NANOAOD
NanoAOD Update: trigger, nPV, pileup (10_0_X)
Fc fix geo test100 x
- mark `PixelDigi` constructor as `explicit` - improve `SiPixelGainCalibrationOffline::getPed` exception error message
- avoid hanging; - reproduce CPU unpacker resultsalso for data.
|
Can you move this to |
| @@ -0,0 +1,94 @@ | |||
| // author: Felice Pantaleo, CERN, 2018 | |||
| #ifndef GPU_SIMPLEVECTOR_H_ | |||
There was a problem hiding this comment.
can you change this to
#ifndef HeterogenousCore_CUDAUtilities_SimpleVector_h
...
fwyzard
changed the base branch from
CMSSW_10_0_X_Patatrack
to
CMSSW_10_1_X_Patatrack
CUDA Vector for easier pushback
|
Merged by 4bec277 |
| @@ -0,0 +1,2 @@ | |||
| <use name="cuda"/> | |||
There was a problem hiding this comment.
I would assume this file is not needed as there is no src directory to compile.
There was a problem hiding this comment.
True, but GPUSimpleVector.h does include CUDA files, so I thought better to add it.
There was a problem hiding this comment.
Ok. (and eventually it is likely needed anyway)
| if (m_size > 0) { | ||
| return m_data[m_size - 1]; | ||
| } else | ||
| return T(); //undefined behaviour |
There was a problem hiding this comment.
Could this be simply return m_data[m_size-1];? For m_size <= 0 the behaviour will be undefined anyway (leading to segfault if we're lucky), so this would allow removing one if.
There was a problem hiding this comment.
OK by me.
In fact it make little sense to return a temporary T() by reference.
And by the way, we should have both
T const & back() const;
T & back();| @@ -0,0 +1,3 @@ | |||
| <bin file="test_GPUSimpleVector.cu" name="test_GPUSimpleVector"> | |||
| <flags CUDA_FLAGS="-std=c++14"/> | |||
There was a problem hiding this comment.
Do I guess correctly that this rule does not need <use name="cuda"/> because the .cu is compiled directly to the executable solely by nvcc?
There was a problem hiding this comment.
I think SCRAM automatically "uses" cuda for .cu files.
Would make sense to add it, though.
There was a problem hiding this comment.
And/or <use name="HeterogeneousCore/CUDAUtilities"/> .
…ms (L1Trigger/TrackFindingTMTT) (cms-sw#29381) * create separate PRs for the two L1TK packages * Improved KF efficiency at high eta * Moved MC data files to cms-data * Removed old file * Removed KF HLS to put instead in external library * Ran scram b code-format * Delete KF4ParamsComb.h.bak * Delete KF4ParamsCombIV.bak * Delete KF4ParamsCombV2.bak * Delete KF5ParamsComb.h.bak * Delete KF4ParamsComb.cc.bak * Delete KF4ParamsCombIV.bak * Delete KF4ParamsCombV2.bak * Delete KF5ParamsComb.cc.bak * L1 tk integration tmtt pre5 (#7) * Added CMS code style fixes * Removed old file * Reapplied stub b code-format * All code review changes (#13) * Fix clang errors (#14) * fixed clang error * directory for MC txt files * Fixed clang warnings + minor simplifications (#15) * tweak * tweak * Fixed clang warnings and small simplifications * Fixed clang warnings and small simplifications * All remaining review comments addressed (#16) * Replaced vector size with empty function * Simplified DegradeBend and StubWindowSuggest * Fixed more review comments * More review comments * code reformat * Ran exhaustive clang tidy * Added library to BuildFile.xml (#17) * Deleted TrackFindingTMT/data/README (#18) * Added library to BuildFile.xml (This was already done yesterday. Not sure why it appears again) * README file in data directory deleted * Fix review comments (#20) Co-authored-by: Louise Skinnari <louise.skinnari@cern.ch>
add Global Tags for geometries T21, T22, T23 and adjust customizations in the upgradeWorkflowComponents file
CUDA vector structure with a simple test file.