Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please ignore: testing cms-bot #17

Closed
wants to merge 1 commit into from
Closed

please ignore: testing cms-bot #17

wants to merge 1 commit into from

Conversation

smuzaffar
Copy link

No description provided.

@smuzaffar
Copy link
Author

ping @cmsbot

@cmsbot
Copy link

cmsbot commented Feb 19, 2018

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_10_1_X_Patatrack.

It involves the following packages:

README

The following packages do not have a category, yet:

README
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbot can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@smuzaffar
Copy link
Author

please test

@cmsbot
Copy link

cmsbot commented Feb 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/cms-jenkins/job/ib-any-integration/21/console Started: 2018/02/19 14:24

@felicepantaleo
Copy link

Thanks Shahzad!

@fwyzard
Copy link

fwyzard commented Feb 19, 2018

Eh, now we have to define the tests...

@smuzaffar
Copy link
Author

@fwyzard , currently I have set it up to run standard cmssw tests. Once you are ready with dedicated tests then we can update cms-bot configuration.

@fwyzard
Copy link

fwyzard commented Feb 19, 2018

Yep, that's what I meant :-)

Also, how do we make it run on a dedicated machine ?

.A

@felicepantaleo
Copy link

@smuzaffar how do we specify on which machine cmsbot runs tests?
We need to run on a machine with a GPU...

@smuzaffar
Copy link
Author

If you have a machine with GPU then we can add it to jenkins. you need to create a local cmsbld account on it and add the cmsbld public key

ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAzHKZxVdp5tF54BJsEOgkQ6rPbhz2w4RznhPlqIM/kmZCL+HN51ofvQPgRWya9coDuuCy2eH5+yJvAZiKRqUlm2QcdUOUmCFYqQKE8WFQVCTGMyMByOHtkf3b+2LtrktIiPp01ElyqQjvoIE++bAmnwKuf3aaK70nmWhrIAQ6BrNfC0vxnx6OOwQcNIyqNHMmi5i49oEUYnwijqm24kngy/reY+ktG3+8fvuISzDru0RKO9pyrtrNg0O772kHY3/MB7GdIgwnJ/bkAvBLa7LEQS9D0EO9TLeJWy6+0IyP5lO0D0Ovillk+0RsWuj4cS7xNnE+xhe+aohuvCP0cwhYwQ== cmsbuild@lxbuild167.cern.ch

in to ~cmsbld/.ssh/authorized_keys

Once we have the machine in jenkins then I can update https://github.com/cms-sw/cms-bot/blob/master/repos/cms_patatrack/cmssw/repo_config.py#L25 so that jobs for this repo can make use of new machine.

@fwyzard
Copy link

fwyzard commented Feb 19, 2018

Do we need to install any specific packages - or will cmsbld take care and install things locally ?

@cmsbot
Copy link

cmsbot commented Feb 19, 2018

-1

Tested at: 6f27c42

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4bec277
You can see more details here:
https://cmssdt.cern.ch/SDT/cms-jenkins-artifacts/pull-request-integration/PR-17/21/git-log-recent-commits
https://cmssdt.cern.ch/SDT/cms-jenkins-artifacts/pull-request-integration/PR-17/21/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/cms-jenkins-artifacts/pull-request-integration/PR-17/21/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found an error when building:

Entering library rule at src/TrackingTools/TrackFitters/plugins
>> Building edm plugin tmp/slc6_amd64_gcc630/src/TrackingTools/TrackRefitter/test/TrajectoryReader/libTrajectoryReader.so
>> Building edm plugin tmp/slc6_amd64_gcc630/src/TrackingTools/TrackRefitter/test/TrackReader/libTrackReader.so
Entering library rule at src/TrackingTools/TrackRefitter/plugins
>> Building binary gpuFrameTransformTest
c++: error: tmp/slc6_amd64_gcc630/src/DataFormats/GeometrySurface/test/gpuFrameTransformTest/gpuFrameTransformKernel.o: No such file or directory
c++: error: tmp/slc6_amd64_gcc630/src/DataFormats/GeometrySurface/test/gpuFrameTransformTest/gpuFrameTransformTest_scramcuda.o: No such file or directory
>> Deleted: tmp/slc6_amd64_gcc630/src/DataFormats/GeometrySurface/test/gpuFrameTransformTest/gpuFrameTransformTest
gmake: *** [tmp/slc6_amd64_gcc630/src/DataFormats/GeometrySurface/test/gpuFrameTransformTest/gpuFrameTransformTest] Error 1
>> Building binary gpuFrameTransformTestRep
c++: error: tmp/slc6_amd64_gcc630/src/DataFormats/GeometrySurface/test/gpuFrameTransformTestRep/gpuFrameTransformKernel.o: No such file or directory

  • Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

Entering library rule at src/Geometry/TrackerGeometryBuilder/plugins
Entering library rule at src/Geometry/TrackerGeometryBuilder/test
>> Compiling LCG dictionary: tmp/slc6_amd64_gcc630/src/DataFormats/GeometrySurface/src/DataFormatsGeometrySurface/a/DataFormatsGeometrySurface_xr.cc
>> Compiling  /build/cmsbld/cms-jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-19-1100/src/HeterogeneousCore/CUDAUtilities/test/test_GPUSimpleVector.cu 
Entering library rule at CondFormats/SiPixelObjects
cc1plus: error: -Werror=potentially-evaluated-expression: no option -Wpotentially-evaluated-expression
cc1plus: warning: unrecognized command line option '-Wno-unused-command-line-argument'
cc1plus: warning: unrecognized command line option '-Wno-unused-private-field'
cc1plus: warning: unrecognized command line option '-Wno-c++11-narrowing'
cc1plus: warning: unrecognized command line option '-Wno-c99-extensions'
>> Compiling  /build/cmsbld/cms-jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-19-1100/src/CondFormats/SiPixelObjects/src/T_EventSetup_SiPixelCPEGenericErrorParm.cc 


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4bec277
You can see more details here:
https://cmssdt.cern.ch/SDT/cms-jenkins-artifacts/pull-request-integration/PR-17/21/git-log-recent-commits
https://cmssdt.cern.ch/SDT/cms-jenkins-artifacts/pull-request-integration/PR-17/21/git-merge-result

@cmsbot
Copy link

cmsbot commented Feb 19, 2018

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@felicepantaleo
Copy link

@smuzaffar , the machine is vinavx2.cern.ch. I added the public key. Could you check if it works?

@smuzaffar
Copy link
Author

Thansk @felicepantaleo , yes cmsbld can login. Can you please also create /data/cmsbld directory owned by cmsbld for jenkins workspace?

@felicepantaleo
Copy link

@smuzaffar done!

@felicepantaleo
Copy link

@smuzaffar let's do it on /data2 as /data is already full...

@smuzaffar
Copy link
Author

smuzaffar commented Feb 20, 2018

please test
lets see if this times tests land on vinavx2.cern.ch

@cmsbot
Copy link

cmsbot commented Feb 20, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/cms-jenkins/job/ib-any-integration/22/console Started: 2018/02/20 12:50

@smuzaffar
Copy link
Author

tests started properly on vinavx2.cern.ch but as default cmssw tests uses production arch i.e. slc6_amd64_gcc630 so tests are runningf or this arch and will fail as vinavx2 is slc7 machine.

@fwyzard
Copy link

fwyzard commented Feb 20, 2018 via email

@cmsbot
Copy link

cmsbot commented Feb 20, 2018

-1

Tested at: 6f27c42

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4bec277
You can see more details here:
https://cmssdt.cern.ch/SDT/cms-jenkins-artifacts/pull-request-integration/PR-17/22/git-log-recent-commits
https://cmssdt.cern.ch/SDT/cms-jenkins-artifacts/pull-request-integration/PR-17/22/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/cms-jenkins-artifacts/pull-request-integration/PR-17/22/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found an error when building:

>> Compiling edm plugin /data2/cmsbld/cms-jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-19-2300/src/DQMServices/Examples/plugins/SealModule.cc 
>> Building binary DQMCollector
tmp/slc6_amd64_gcc630/src/DQMServices/Core/bin/DQMCollector/DQMCollector.o: In function `main':
DQMCollector.cpp:(.text.startup+0xf7): undefined reference to `lat::Signal::handleFatal(char const*, int, bool (*)(int, siginfo_t*, void*), void (*)(int, siginfo_t*, void*), unsigned int)'
DQMCollector.cpp:(.text.startup+0x10a): undefined reference to `lat::Signal::handle(int, void (*)(int, siginfo_t*, void*), __sigset_t const*)'
collect2: error: ld returned 1 exit status
>> Deleted: tmp/slc6_amd64_gcc630/src/DQMServices/Core/bin/DQMCollector/DQMCollector
gmake: *** [tmp/slc6_amd64_gcc630/src/DQMServices/Core/bin/DQMCollector/DQMCollector] Error 1
Entering library rule at src/SLHCUpgradeSimulations/Geometry/test
Entering library rule at src/SLHCUpgradeSimulations/Geometry/test
Entering library rule at src/SLHCUpgradeSimulations/Geometry/test

  • Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /data2/cmsbld/cms-jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-19-2300/src/Geometry/TrackerGeometryBuilder/src/ProxyStripTopology.cc 
>> Compiling  /data2/cmsbld/cms-jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-19-2300/src/Geometry/TrackerGeometryBuilder/src/TrackerGeomBuilderFromGeometricDet.cc 
>> Compiling  /data2/cmsbld/cms-jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-19-2300/src/Geometry/TrackerGeometryBuilder/src/ProxyPixelTopology.cc 
>> Compiling  /data2/cmsbld/cms-jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-19-2300/src/Geometry/TrackerGeometryBuilder/src/trackerHierarchy.cc 
>> Compiling  /data2/cmsbld/cms-jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-19-2300/src/Geometry/TrackerGeometryBuilder/src/StripTopologyBuilder.cc 
cc1plus: error: -Werror=potentially-evaluated-expression: no option -Wpotentially-evaluated-expression
cc1plus: warning: unrecognized command line option '-Wno-unused-command-line-argument'
cc1plus: warning: unrecognized command line option '-Wno-unused-private-field'
cc1plus: warning: unrecognized command line option '-Wno-c++11-narrowing'
cc1plus: warning: unrecognized command line option '-Wno-c99-extensions'
gmake: *** [tmp/slc6_amd64_gcc630/src/HeterogeneousCore/CUDAUtilities/test/test_GPUSimpleVector/test_GPUSimpleVector.o] Error 1


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4bec277
You can see more details here:
https://cmssdt.cern.ch/SDT/cms-jenkins-artifacts/pull-request-integration/PR-17/22/git-log-recent-commits
https://cmssdt.cern.ch/SDT/cms-jenkins-artifacts/pull-request-integration/PR-17/22/git-merge-result

@cmsbot
Copy link

cmsbot commented Feb 20, 2018

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@fwyzard
Copy link

fwyzard commented Feb 28, 2018

Looks like @cmsbot is working as intended: we need to make adjustments and fix some compilation flags, but we can adjust them as we go.

@fwyzard fwyzard closed this Feb 28, 2018
fwyzard pushed a commit that referenced this pull request Jul 19, 2018
Update branch CMSSW_10_2_X to cms-sw
fwyzard pushed a commit that referenced this pull request May 23, 2020
…ms (L1Trigger/TrackFindingTMTT) (cms-sw#29381)

* create separate PRs for the two L1TK packages

* Improved KF efficiency at high eta

* Moved MC data files to cms-data

* Removed old file

* Removed KF HLS to put instead in external library

* Ran scram b code-format

* Delete KF4ParamsComb.h.bak

* Delete KF4ParamsCombIV.bak

* Delete KF4ParamsCombV2.bak

* Delete KF5ParamsComb.h.bak

* Delete KF4ParamsComb.cc.bak

* Delete KF4ParamsCombIV.bak

* Delete KF4ParamsCombV2.bak

* Delete KF5ParamsComb.cc.bak

* L1 tk integration tmtt pre5 (#7)

* Added CMS code style fixes

* Removed old file

* Reapplied stub b code-format

* All code review changes (#13)

* Fix clang errors (#14)

* fixed clang error

* directory for MC txt files

* Fixed clang warnings + minor simplifications (#15)

* tweak

* tweak

* Fixed clang warnings and small simplifications

* Fixed clang warnings and small simplifications

* All remaining review comments addressed (#16)

* Replaced vector size with empty function

* Simplified DegradeBend and StubWindowSuggest

* Fixed more review comments

* More review comments

* code reformat

* Ran exhaustive clang tidy

* Added library to BuildFile.xml (#17)

* Deleted TrackFindingTMT/data/README (#18)

* Added library to BuildFile.xml (This was already done yesterday. Not sure why it appears again)

* README file in data directory deleted

* Fix review comments (#20)

Co-authored-by: Louise Skinnari <louise.skinnari@cern.ch>
fwyzard pushed a commit that referenced this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants