Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EcalUncalibRecHitProducerGPU: remove unused "shouldTransferToHost" parameter #463

Merged
merged 1 commit into from
May 18, 2020
Merged

EcalUncalibRecHitProducerGPU: remove unused "shouldTransferToHost" parameter #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions HLTrigger/Configuration/python/customizeHLTforPatatrack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,7 @@ def customise_gpu_ecal(process):
outOfTimeThresholdGain61pEE = cms.double(1000.0),
kernelMinimizeThreads = cms.vuint32(32, 1, 1),
maxNumberHits = cms.uint32(20000),
shouldRunTimingComputation = cms.bool(False),
shouldTransferToHost = cms.bool(True)
shouldRunTimingComputation = cms.bool(False)
)

process.hltEcalUncalibRecHitSoA = cms.EDProducer("EcalCPUUncalibRecHitProducer",
Expand Down
5 changes: 0 additions & 5 deletions RecoLocalCalo/EcalRecProducers/plugins/EcalUncalibRecHitProducerGPU.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ class EcalUncalibRecHitProducerGPU : public edm::stream::EDProducer<edm::Externa
// event data
ecal::multifit::EventOutputDataGPU eventOutputDataGPU_;
ecal::multifit::EventDataForScratchGPU eventDataForScratchGPU_;
bool shouldTransferToHost_{true};

cms::cuda::ContextState cudaState_;

Expand Down Expand Up @@ -128,7 +127,6 @@ void EcalUncalibRecHitProducerGPU::fillDescriptions(edm::ConfigurationDescriptio
desc.add<double>("amplitudeThresholdEB", 10);
desc.add<double>("amplitudeThresholdEE", 10);
desc.add<uint32_t>("maxNumberHits", 20000); //---- AM TEST
desc.add<bool>("shouldTransferToHost", true);
desc.add<std::vector<uint32_t>>("kernelMinimizeThreads", {32, 1, 1});
// ---- default false or true? It was set to true, but at HLT it is false
desc.add<bool>("shouldRunTimingComputation", false);
Expand Down Expand Up @@ -174,9 +172,6 @@ EcalUncalibRecHitProducerGPU::EcalUncalibRecHitProducerGPU(const edm::ParameterS
// max number of digis to allocate for
maxNumberHits_ = ps.getParameter<uint32_t>("maxNumberHits");

// transfer to host switch
shouldTransferToHost_ = ps.getParameter<bool>("shouldTransferToHost");

// switch to run timing computation kernels
configParameters_.shouldRunTimingComputation = ps.getParameter<bool>("shouldRunTimingComputation");

Expand Down