Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EcalUncalibRecHitProducerGPU: remove unused "shouldTransferToHost" parameter #463

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented May 16, 2020

No description provided.

@fwyzard fwyzard requested a review from amassiro May 16, 2020 05:46
@fwyzard fwyzard added the ECAL ECAL-related developments label May 16, 2020
@fwyzard fwyzard self-assigned this May 16, 2020
@fwyzard
Copy link
Author

fwyzard commented May 16, 2020

As far as I can see, that parameter is not actually used ?

Copy link

@amassiro amassiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it is not used. I think it comes from older implementation of the code, used during first developments.

@fwyzard fwyzard merged commit d4b30cb into cms-patatrack:CMSSW_11_1_X_Patatrack May 18, 2020
@fwyzard
Copy link
Author

fwyzard commented May 18, 2020

Thanks.

@fwyzard fwyzard deleted the EcalUncalibRecHitProducerGPU_remove_shouldTransferToHost_parameter branch May 18, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ECAL ECAL-related developments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants