Dynamic Reconfigure for AMCL #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* not finished * update * satisfying linters * add mutex * fix mistake * dealing each parameters * segregating variables and instantiating the objects correspondingly * remove unwanted mutex * reconfigure for map topic * review update * careful updation of min and max particles * resetting and reinitilaizing the laser scanner and message filters * fixing the mutex
dimaxano
requested review from
arekin19,
artemiialessandrini and
TanmayDeshmukh
TanmayDeshmukh
approved these changes
Jan 17, 2023
artemiialessandrini
approved these changes
Jan 19, 2023
arekin19
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Change parameters on the fly
Approach
The main functionality is taken from upstream, I just added support for our custom parameters and fixed pose restart when updating particle filter parameters