Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to decrease AMCL's laser confidence #22

Closed
dimaxano opened this issue Dec 19, 2022 · 7 comments
Closed

Add parameter to decrease AMCL's laser confidence #22

dimaxano opened this issue Dec 19, 2022 · 7 comments
Assignees

Comments

@dimaxano
Copy link

One should have a chance to change param value on the fly and apply that change. Either via separate service or parameter_server

@dimaxano dimaxano self-assigned this Dec 19, 2022
@artemiialessandrini
Copy link

Shall we introduce dynamic reconfiguring for AMCL? It's been stable in ROS2 for some time

@dimaxano
Copy link
Author

Seems like one of the options
Do you maybe have some examples of ROS2 packages where it is implemented?

@artemiialessandrini
Copy link

ros-navigation#2932

@artemiialessandrini
Copy link

artemiialessandrini commented Dec 20, 2022

We have this PR :)
It looks cherry-pickable
I've been thinking about dynamically changing the laser model weights
If it won't work, dynamic reconfiguring will be useful for calibration

@dimaxano
Copy link
Author

Very nice! I'll check it, but I have concern that it restarts everything. How robot will behave if we change params during the movement?

@artemiialessandrini
Copy link

The concept is to dynamically change parameters without unexpected behaviors, crashes or restarts.
Maybe there're some parameters we shouldn't tweak during the run just by definition.
But other than that it's ok :)

@dimaxano
Copy link
Author

#26
#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants