-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update new github-action and subnet vpc tag #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_example/main.tf
Outdated
Comment on lines
5
to
16
module "s3_bucket" { | ||
source = "clouddrove/s3/aws" | ||
version = "1.3.0" | ||
|
||
name = "clouddrove-sftp-bucket" | ||
environment = "test" | ||
label_order = ["environment", "name"] | ||
|
||
versioning = true | ||
acl = "private" | ||
force_destroy = true | ||
} |
Check warning
Code scanning / defsec
S3 Bucket does not have logging enabled. Warning
Bucket does not have logging enabled
_example/main.tf
Outdated
Comment on lines
5
to
16
module "s3_bucket" { | ||
source = "clouddrove/s3/aws" | ||
version = "1.3.0" | ||
|
||
name = "clouddrove-sftp-bucket" | ||
environment = "test" | ||
label_order = ["environment", "name"] | ||
|
||
versioning = true | ||
acl = "private" | ||
force_destroy = true | ||
} |
Check warning
Code scanning / defsec
S3 Data should be versioned Warning
Bucket does not have versioning enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
added new vpc and subnet tag
added new github-action
why
`need to update vpc and subnet tag
need to update github-action