feat: update new github-action and subnet vpc tag (#21)

* feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action and subnet vpc tag * feat: update new github-action * feat: update tflint gihub-action * feat: update tflint gihub-action * feat: update tflint gihub-action * feat: update tflint gihub-action * feat: update tflint gihub-action * feat: update tflint gihub-action * feat: update tflint gihub-action
clouddrove · Aug 3, 2023 · 4451e09 · 4451e09
1 parent 04046ae
commit 4451e09
Show file tree

Hide file tree

Showing 20 changed files with 97 additions and 237 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -0,0 +1,2 @@
+# These owners will be the default owners for everything in the repo.
+*    @anmolnagpal @clouddrove/approvers @clouddrove-ci
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,12 @@
+## what
+* Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
+* Use bullet points to be concise and to the point.
+
+## why
+* Provide the justifications for the changes (e.g. business case).
+* Describe why these changes were made (e.g. why do these commits fix the problem?)
+* Use bullet points to be concise and to the point.
+
+## references
+* Link to any supporting jira issues or helpful documentation to add some context (e.g. stackoverflow).
+* Use `closes #123`, if this PR closes a Jira issue `#123`
diff --git a/.github/workflows/auto_assignee.yml b/.github/workflows/auto_assignee.yml
@@ -0,0 +1,14 @@
+name: Auto Assign PRs
+
+on:
+  pull_request:
+    types: [opened, reopened]
+
+  workflow_dispatch:
+jobs:
+  assignee:
+    uses: clouddrove/github-shared-workflows/.github/workflows/auto_assignee.yml@master
+    secrets:
+      GITHUB: ${{ secrets.GITHUB }}
+    with:
+      assignees: 'clouddrove-ci'
diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml
@@ -10,4 +10,4 @@ jobs:
     uses: clouddrove/github-shared-workflows/.github/workflows/changelog.yml@master
     secrets: inherit
     with:
-      branch: 'master'
+      branch: 'master'
diff --git a/.github/workflows/readme.yml b/.github/workflows/readme.yml
@@ -5,42 +5,42 @@ on:
       - master
 
 jobs:
-  readme-create:
+  readme:
     name: 'readme-create'
     runs-on: ubuntu-latest
     steps:
       - name: 'Checkout'
-        uses: actions/checkout@v2.3.4
+        uses: actions/checkout@master
 
       - name: 'Set up Python 3.7'
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
           python-version: '3.x'
 
       - name: 'create readme'
-        uses: 'clouddrove/github-actions@v8.0'
+        uses: 'clouddrove/github-actions@v9.0.2'
         with:
           actions_subcommand: 'readme'
-          github_token: '${{ secrets.GITHUB}}'
+          github_token: '${{ secrets.GITHUB }}'
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN}}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
 
       - name: 'pre-commit check errors'
-        uses: pre-commit/action@v2.0.0
+        uses: pre-commit/action@v3.0.0
         continue-on-error: true
 
-      - name: 'pre-commit fix errors'
-        uses: pre-commit/action@v2.0.0
+      - name: 'pre-commit fix erros'
+        uses: pre-commit/action@v3.0.0
         continue-on-error: true
 
       - name: 'push readme'
-        uses: 'clouddrove/github-actions@v8.0'
+        uses: 'clouddrove/github-actions@v9.0.2'
         continue-on-error: true
         with:
           actions_subcommand: 'push'
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN}}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: 'Slack Notification'
         uses: clouddrove/action-slack@v2

diff --git a/.github/workflows/terraform.yml b/.github/workflows/terraform.yml
diff --git a/.github/workflows/terratest.yml b/.github/workflows/terratest.yml
diff --git a/.github/workflows/tf-checks.yml b/.github/workflows/tf-checks.yml
@@ -0,0 +1,11 @@
+name: tf-checks
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+  workflow_dispatch:
+jobs:
+  example:
+    uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@master
+    with:
+      working_directory: './_example/'
diff --git a/.github/workflows/tflint.yml b/.github/workflows/tflint.yml
@@ -0,0 +1,11 @@
+name: tf-lint
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+  workflow_dispatch:
+jobs:
+  tflint:
+    uses: clouddrove/github-shared-workflows/.github/workflows/tf-lint.yml@master
+    secrets:
+      GITHUB: ${{ secrets.GITHUB }}
diff --git a/.github/workflows/tfsec.yml b/.github/workflows/tfsec.yml
@@ -8,4 +8,4 @@ jobs:
     uses: clouddrove/github-shared-workflows/.github/workflows/tfsec.yml@master
     secrets: inherit
     with:
-      working_directory: '.'
+      working_directory: '.'
diff --git a/README.md b/README.md
@@ -83,7 +83,7 @@ Here is an example of how you can use this module in your inventory structure:
         name                      = "sftp"
         environment               = "test"
         label_order               = ["name", "environment"]
-        key_path                  = "~/.ssh/id_rsa.pub"
+        key_path                  = "~/.ssh/rsa"
         user_name                 = "ftp-user"
         enable_sftp               = true
         s3_bucket_id              = clouddrove_dev_s3_bucket

diff --git a/README.yaml b/README.yaml
@@ -15,19 +15,15 @@ github_repo: clouddrove/terraform-aws-sftp
 
 # Badges to display
 badges:
-  - name: "Terraform"
-    image: "https://img.shields.io/badge/Terraform-v1.1.7-green"
-    url: "https://www.terraform.io"
-  - name: "Licence"
-    image: "https://img.shields.io/badge/License-APACHE-blue.svg"
-    url: "LICENSE.md"
+  - name: "Latest Release"
+    image: "https://img.shields.io/github/release/clouddrove/terraform-aws-sftp.svg"
+    url: "https://github.com/clouddrove/terraform-aws-sftp/releases/latest"
   - name: "tfsec"
     image: "https://github.com/clouddrove/terraform-aws-sftp/actions/workflows/tfsec.yml/badge.svg"
     url: "https://github.com/clouddrove/terraform-aws-sftp/actions/workflows/tfsec.yml"
-  - name: "static-checks"
-    image: "https://github.com/clouddrove/terraform-aws-sftp/actions/workflows/terraform.yml/badge.svg"
-    url: "https://github.com/clouddrove/terraform-aws-sftp/actions/workflows/terraform.yml"
-
+  - name: "Licence"
+    image: "https://img.shields.io/badge/License-APACHE-blue.svg"
+    url: "LICENSE.md"
 
 #  description of this project
 description: |-
@@ -37,6 +33,7 @@ description: |-
 include:
   - "terraform.md"
 
+# How to use this project
 # How to use this project
 usage : |-
   ### Simple Example
@@ -48,7 +45,7 @@ usage : |-
           name                      = "sftp"
           environment               = "test"
           label_order               = ["name", "environment"]
-          key_path                  = "~/.ssh/id_rsa.pub"
+          public_key                = ""
           user_name                 = "ftp-user"
           enable_sftp               = true
           s3_bucket_id              = clouddrove_dev_s3_bucket

diff --git a/_example/example.tf → _example/main.tf b/_example/example.tf → _example/main.tf
diff --git a/_example/outputs.tf b/_example/outputs.tf
@@ -1,5 +1,5 @@
 output "id" {
-  value       = module.sftp.*.id
+  value       = module.sftp[*].id
   description = "The Server ID of the Transfer Server (e.g. s-12345678)"
 }
 

diff --git a/_example/versions.tf b/_example/versions.tf
@@ -1,11 +1,11 @@
 # Terraform version
 terraform {
-  required_version = ">= 1.3.6"
+  required_version = ">= 1.5.0"
 
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = ">= 4.48.0"
+      version = ">= 5.9.0"
     }
   }
 }
diff --git a/_test/sftp_test.go b/_test/sftp_test.go