Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update figwheel instructions #3348

Merged
merged 1 commit into from
May 30, 2023
Merged

Update figwheel instructions #3348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/modules/ROOT/pages/cljs/figwheel.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ deps.edn.
----
{:aliases {:fig {:extra-deps
{com.bhauman/rebel-readline-cljs {:mvn/version "0.1.4"}
com.bhauman/figwheel-main {:mvn/version "0.2.3"}}}}}
com.bhauman/figwheel-main {:mvn/version "0.2.17"}}}
:build {:main-opts ["-m" "figwheel.main" "-b" "dev" "-r"]}}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's name the alias fig-build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well this is exactly what prompted me to submit the PR, that the alias name (and the shape of the map) did not matched this https://github.com/bhauman/figwheel-main-template#compiling-the-generated-project

And it is already hinted in CIDER docs:

These should already be present if you used the figwheel-main-template with clj-new to generate your deps.edn

but the alias shown is not the one already present in the template.

Sorry for the confusion!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

----
+
. Add this option to your project's `.dir-locals.el` before opening the
Expand All @@ -77,7 +78,7 @@ use `revert-buffer`.)
+
[source,lisp]
----
((clojurescript-mode . ((cider-clojure-cli-aliases . "-A:fig"))))
((clojurescript-mode . ((cider-clojure-cli-aliases . "-M:fig:build"))))
----

TIP: If you didn't setup `.dir-locals.el` you can edit the command-line
Expand Down