Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update figwheel instructions #3348

Merged

Conversation

zzantares
Copy link
Contributor

I was trying to follow the documentation but it did not work. This is to match
what figwheel-main-template produces, it could trip up new ClojureScript
users.

When using -A I got a warning about it being deprecated in favour of -M,
I'm hacking in a local project and following the updated instructions works.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

This is to match what figwheel-main-template produces, it could trip up new
ClojureScript users.
Copy link
Member

@vemv vemv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks much for your contribution!

@@ -67,7 +67,8 @@ deps.edn.
----
{:aliases {:fig {:extra-deps
{com.bhauman/rebel-readline-cljs {:mvn/version "0.1.4"}
com.bhauman/figwheel-main {:mvn/version "0.2.3"}}}}}
com.bhauman/figwheel-main {:mvn/version "0.2.17"}}}
:build {:main-opts ["-m" "figwheel.main" "-b" "dev" "-r"]}}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's name the alias fig-build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well this is exactly what prompted me to submit the PR, that the alias name (and the shape of the map) did not matched this https://github.com/bhauman/figwheel-main-template#compiling-the-generated-project

And it is already hinted in CIDER docs:

These should already be present if you used the figwheel-main-template with clj-new to generate your deps.edn

but the alias shown is not the one already present in the template.

Sorry for the confusion!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@bbatsov bbatsov merged commit ec97c88 into clojure-emacs:master May 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants