Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: benchmarking affine transforms #197

Merged
merged 10 commits into from
Jul 24, 2024
Merged

Conversation

haesleinhuepf
Copy link
Member

This demonstrates the issues reported in #196

@StRigaud
Copy link
Member

@haesleinhuepf I have added a deprecated function with warning as well as a converter for numpy to list.

Doing it reveled a few issues:

  • interpolate do not work, if set to yes, it returns an empty image, we need to investigate
  • the scale function may also have an issue (tbc)

@StRigaud
Copy link
Member

closes #196

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.91%. Comparing base (e268b8e) to head (c030924).

Files Patch % Lines
pyclesperanto/_interroperability.py 56.25% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
- Coverage   85.17%   84.91%   -0.26%     
==========================================
  Files          18       18              
  Lines        1814     1830      +16     
==========================================
+ Hits         1545     1554       +9     
- Misses        269      276       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud
Copy link
Member

StRigaud commented Jul 9, 2024

Interpolation returns 0 image. This is fixed by clEsperanto/CLIc#310 which will be available in the next release of CLIc and pyclesperanto

@StRigaud
Copy link
Member

This should work now with the 0.11.0 release (clEsperanto/CLIc#317 && clEsperanto/CLIc#310)

@StRigaud StRigaud marked this pull request as ready for review July 17, 2024 12:30
@StRigaud
Copy link
Member

Notebook runs, with interpolation and deprecated warning.

Ready to be merged

@StRigaud StRigaud merged commit 2472362 into main Jul 24, 2024
8 checks passed
@StRigaud StRigaud deleted the benchmarking-affine-transform branch July 24, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Affine transform: parameter names changed compared to the prototype
3 participants