Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-affine-interpolation #310

Merged
merged 13 commits into from
Jul 9, 2024
Merged

Fix-affine-interpolation #310

merged 13 commits into from
Jul 9, 2024

Conversation

StRigaud
Copy link
Member

@StRigaud StRigaud commented Jun 25, 2024

@StRigaud
Copy link
Member Author

Require to solve the issue: clEsperanto/clij-opencl-kernels#40

@StRigaud
Copy link
Member Author

StRigaud commented Jul 5, 2024

I roled back interpolation kernel to its correct code, using float type read coordinate.
I enable float type coordinate for IMAGE type memory in the defines
If interpolation is requested: we copy the src buffer into an image memory type

Interpolation still fail though: the kernel is reading 0 values everywhere ...

@StRigaud StRigaud marked this pull request as ready for review July 8, 2024 16:46
@StRigaud
Copy link
Member Author

StRigaud commented Jul 8, 2024

This should fix the interpolate option on the transform, as well as an other issue related to IMAGE which was making OpenCL to always read 0 from cl_image.

Interpolation results (here scale up of factor 2) was compared with FIJI billinear.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 18.46154% with 53 lines in your changes missing coverage. Please review.

Project coverage is 47.93%. Comparing base (cbf4ec1) to head (dca0190).

Files Patch % Lines
clic/src/execution.cpp 24.39% 2 Missing and 29 partials ⚠️
clic/src/openclbackend.cpp 7.14% 13 Missing ⚠️
clic/src/transform.cpp 10.00% 1 Missing and 8 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   47.34%   47.93%   +0.58%     
==========================================
  Files         235      235              
  Lines        3128     3146      +18     
  Branches     1550     1571      +21     
==========================================
+ Hits         1481     1508      +27     
+ Misses        419      368      -51     
- Partials     1228     1270      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud StRigaud merged commit 2c3be4b into master Jul 9, 2024
5 checks passed
@StRigaud StRigaud deleted the fix-affine-interpolation branch July 9, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Interpolation in transform operation does not work
2 participants