-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Allow cache eviction for HNSW provider #2484
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Ishiihara and the rest of your teammates on |
35113b6
to
a7f5120
Compare
2dc80ad
to
04f0db4
Compare
a7f5120
to
38a85c2
Compare
04f0db4
to
74fc086
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Would like us to use try_from_config > new for config and also there are some cleanups like out of date TODOs
38a85c2
to
a6e03f6
Compare
8e97d51
to
02d53de
Compare
a6e03f6
to
f28621a
Compare
02d53de
to
7181c95
Compare
7181c95
to
9df321c
Compare
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?