-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Introduce stream abstraction and enable concurrency test for blockfile #2454
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Ishiihara and the rest of your teammates on |
9b2ec43
to
a83763d
Compare
b253dcc
to
ce5123c
Compare
a83763d
to
35113b6
Compare
a7f5120
to
38a85c2
Compare
@@ -20,15 +21,15 @@ impl LocalStorage { | |||
pub(crate) async fn get( | |||
&self, | |||
key: &str, | |||
) -> Result<Box<dyn AsyncBufRead + Unpin + Send>, String> { | |||
) -> Result<Box<dyn Stream<Item = ByteStreamItem> + Unpin + Send>, String> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need this impl still? Can't we just get rid of it and only use SyncLocalStorage?
@@ -128,44 +132,71 @@ impl HnswIndexProvider { | |||
// Fetch the files from storage and put them in the index storage path | |||
for file in FILES.iter() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you copy the current tracing on main?
ce5123c
to
3bcf445
Compare
38a85c2
to
a6e03f6
Compare
a6e03f6
to
f28621a
Compare
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?