Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tools): Swapped sign of KKO and GBO rotation #62

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix(tools): Swapped sign of KKO and GBO rotation #62

merged 1 commit into from
Jul 13, 2023

Conversation

lazdam
Copy link
Contributor

@lazdam lazdam commented Jul 13, 2023 •
edited
Loading

@bandersen441 noticed that the signs of KKO and GBO were incorrectly assigned while generating ringmaps for GBO. Addressing this issue now by quickly swapping signs.

aelanman
aelanman approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@aelanman aelanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative!

kiyo-masui
kiyo-masui approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@kiyo-masui kiyo-masui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lazdam lazdam merged commit f8c7162 into master Jul 13, 2023
4 checks passed
@lazdam lazdam deleted the ml/flip_outrigger_rotation branch July 13, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiyo-masui kiyo-masui kiyo-masui approved these changes

@aelanman aelanman aelanman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazdam @kiyo-masui @aelanman