Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unzip of chef-workstation-app (Electron-App) #477

Merged
merged 7 commits into from
Sep 9, 2019
Merged

Fix unzip of chef-workstation-app (Electron-App) #477

merged 7 commits into from
Sep 9, 2019

Commits on Sep 6, 2019

  1. Electron changed the folder it zips the app into, need to change upzi… 

    …p correspondingly

Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball authored and Salim Afiune committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    0fbcc9b View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2019

  1. Merge branch 'master' of https://github.com/chef/chef-workstation int… 

    …o afiune/upgrade-electron
    Salim Afiune committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    5d55f38 View commit details
    Browse the repository at this point in the history

  2. Add single quotes to generated zip file 

    For some reason the generated zip file has single quotes in the file
name, lets try to fix the packaging of the chef-workstation-app by
adding them. Ugly! I know. 😭

Signed-off-by: Salim Afiune <afiune@chef.io>
    Salim Afiune committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    756c738 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Update comments 

    Signed-off-by: Salim Afiune <afiune@chef.io>
    Salim Afiune committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    e781217 View commit details
    Browse the repository at this point in the history

  2. [MacOS] Verify chef-workstation-app was installed 

    Signed-off-by: Salim Afiune <afiune@chef.io>
    Salim Afiune committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    a589da8 View commit details
    Browse the repository at this point in the history

  3. Remove single quotes and avoid removing mac/ dir 

    Maybe this is the problem we are facing, since there is no more mac/ dir
then the postinstall fails. I think!

Signed-off-by: Salim Afiune <afiune@chef.io>
    Salim Afiune committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    0f7682d View commit details
    Browse the repository at this point in the history

  4. Adds echo message to output mac verification 

    Signed-off-by: Salim Afiune <afiune@chef.io>
    Salim Afiune committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    f64fe64 View commit details
    Browse the repository at this point in the history