Fix unzip of chef-workstation-app (Electron-App) #477
Conversation
…p correspondingly Signed-off-by: tyler-ball <tball@chef.io>
|
Can we get a test added to workstation so we know we're actually installing the app? This would have been a really nasty regression if we had missed it. |
…o afiune/upgrade-electron
For some reason the generated zip file has single quotes in the file name, lets try to fix the packaging of the chef-workstation-app by adding them. Ugly! I know. 😭 Signed-off-by: Salim Afiune <afiune@chef.io>
afiune
force-pushed
the
afiune/upgrade-electron
branch
from
f859071
to
756c738
Compare
afiune
changed the title
|
We are still trying to figure out the problem, please hold on merge. 😉 |
Signed-off-by: Salim Afiune <afiune@chef.io>
afiune
force-pushed
the
afiune/upgrade-electron
branch
from
609f704
to
f03b358
Compare
Signed-off-by: Salim Afiune <afiune@chef.io>
tyler-ball
added
Aspect: Correctness
Aspect: Packaging
afiune
force-pushed
the
afiune/upgrade-electron
branch
from
f03b358
to
a589da8
Compare
|
Lets potentially get #474 fixed as part of this PR |
Maybe this is the problem we are facing, since there is no more mac/ dir then the postinstall fails. I think! Signed-off-by: Salim Afiune <afiune@chef.io>
| unzip chef-workstation-app-mac.zip | ||
| sudo rm -rf "/Applications/Chef Workstation App.app" | ||
| sudo mv "mac/Chef Workstation App.app" /Applications | ||
| rm -r mac |
There was a problem hiding this comment.
I think that this rm command made the postinst script to stop processing the rest of the commands in the script. Maybe this is the solution 🤞
afiune
changed the title
|
Waiting on this build to finish and then test the installer: https://buildkite.com/chef/chef-chef-workstation-master-omnibus-adhoc/builds/63 I have already added a test for MacOS to verify that we are installing the 'Chef Workstation App', but it is missing something similar for Windows. |
|
You got this Adhoc Build!!! |
Signed-off-by: Salim Afiune <afiune@chef.io>
|
I have verified that we have fixed the major bug introduced with the upgrade of Electron, now the Chef Workstation App continues to be installed on the system!
Merging! |
Electron changed the folder it zips the app into, needs to change unzip correspondingly
Also closes #474
Signed-off-by: tyler-ball tball@chef.io