Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid sparse key read for non sparse secrets #280

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Avoid sparse key read for non sparse secrets #280

merged 1 commit into from
Jun 7, 2017

Commits on Jun 7, 2017

  1. Avoid sparse key read for non sparse secrets 

    Before this patch, every call to ChefVault::Item.load used to call the
chef server for sparse key twice:
- once to load keys
- once to decrypt symetrical key

This has a huge cost on secret read for nodes whose latency to the chef
server is high (we have example with ~300ms ping time).

This patch make sure we don't try to read sparse key when the secret is
marked as non sparse.

Change-Id: Ib0c493845ccd8d0630c00010b5f48a6a264f81dc
Signed-off-by: Grégoire Seux <g.seux@criteo.com>
    @kamaradclimber
    kamaradclimber committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    42f2aa6 View commit details
    Browse the repository at this point in the history