Avoid sparse key read for non sparse secrets #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thommay
approved these changes
Jun 6, 2017
Before this patch, every call to ChefVault::Item.load used to call the chef server for sparse key twice: - once to load keys - once to decrypt symetrical key This has a huge cost on secret read for nodes whose latency to the chef server is high (we have example with ~300ms ping time). This patch make sure we don't try to read sparse key when the secret is marked as non sparse. Change-Id: Ib0c493845ccd8d0630c00010b5f48a6a264f81dc Signed-off-by: Grégoire Seux <g.seux@criteo.com>
kamaradclimber
force-pushed
the
on_sparse_key_perf
branch
from
430f1f9
to
42f2aa6
Compare
|
appveyor test refuses to launch, I've repushed to retry with the same result. @thommay could you have a quick look and tell me when I can retry? |
|
Appveyor is a bit daft, but that's green now. Thanks! |
|
Thanks for your quick feedback 😀
Le mer. 7 juin 2017 09:43, Thom May <notifications@github.com> a écrit :
… Merged #280 <#280>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#280 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAeu8UEBI3Vw7wf6P7bkepe1Z9KdppcAks5sBlSqgaJpZM4Nxm1L>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, every call to ChefVault::Item.load used to call the
chef server for sparse key twice:
This has a huge cost on secret read for nodes whose latency to the chef
server is high (we have example with ~300ms ping time).
This patch make sure we don't try to read sparse key when the secret is
marked as non sparse.
Signed-off-by: Grégoire Seux g.seux@criteo.com