Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume all nodes matching the search query are valid nodes #272

Merged
merged 1 commit into from
May 15, 2017

Commits on Apr 27, 2017

  1. Assume all nodes matching the search query are valid nodes

    Previously we checked if nodes were matching search query AND had an existing chef key.
    This patch assumes that all nodes have exiting chef keys.
    
    Experience I have with chef is that nodes without proper keys are bugs and needs
    to be fixed anyway (either have a key or be removed).
    
    This patch allows to make usage of --clean-unknown-clients much faster (avoid
    querying chef-server for each node) especially on secrets encrypted for many
    nodes (where search query time is small compared to querying all clients)
    
    This introduces a small change in behavior:
    - before: existing nodes without client would be cleanup by --clean-unknown-clients
    - now: such nodes are not cleaned. They will be cleaned when node will be removed
    
    Change-Id: If45da1faec5c36026a75762afe4bad08cab97f64
    Signed-off-by: Grégoire Seux <g.seux@criteo.com>
    kamaradclimber committed Apr 27, 2017
    Configuration menu
    Copy the full SHA
    342e9c5 View commit details
    Browse the repository at this point in the history