Assume all nodes matching the search query are valid nodes #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm of course willing to discuss the assumption "all nodes have a client" (got no answer on slack https://chefcommunity.slack.com/archives/C0M1NGZE3/p1493210220884148). |
|
Yeah, I don't really understand why you'd get to a position of having nodes without clients, unless you have a terrible reaper program that only deletes clients. |
|
Ill fix test tomorrow morning. Tjanks for the very early feedback
Le mer. 26 avr. 2017 17:27, Thom May <notifications@github.com> a écrit :
… Yeah, I don't really understand why you'd get to a position of having
nodes without clients, unless you have a terrible reaper program that only
deletes clients.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#272 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAeu8WZ7ZFMbG6TAQjUQggQF2nrfcPxSks5rz2JlgaJpZM4NJA9h>
.
|
Previously we checked if nodes were matching search query AND had an existing chef key. This patch assumes that all nodes have exiting chef keys. Experience I have with chef is that nodes without proper keys are bugs and needs to be fixed anyway (either have a key or be removed). This patch allows to make usage of --clean-unknown-clients much faster (avoid querying chef-server for each node) especially on secrets encrypted for many nodes (where search query time is small compared to querying all clients) This introduces a small change in behavior: - before: existing nodes without client would be cleanup by --clean-unknown-clients - now: such nodes are not cleaned. They will be cleaned when node will be removed Change-Id: If45da1faec5c36026a75762afe4bad08cab97f64 Signed-off-by: Grégoire Seux <g.seux@criteo.com>
kamaradclimber
force-pushed
the
non_strict_client_check
branch
from
173093f
to
342e9c5
Compare
thommay
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we checked if nodes were matching search query AND had an existing chef key.
This patch assumes that all nodes have exiting chef keys.
Experience I have with chef is that nodes without proper keys are bugs and needs
to be fixed anyway (either have a key or be removed).
This patch allows to make usage of --clean-unknown-clients much faster (avoid
querying chef-server for each node) especially on secrets encrypted for many
nodes (where search query time is small compared to querying all clients)
Signed-off-by: Grégoire Seux g.seux@criteo.com