-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install and setup playwright, successfully run example test #701
Conversation
client/__tests__/common/constants.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of these constants may be pruned at the end of the migration, I will run a JS util to see what exports are not being imported/used anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat-playwright #701 +/- ##
================================================
Coverage 77.67% 77.67%
================================================
Files 88 88
Lines 6772 6772
================================================
Hits 5260 5260
Misses 1512 1512
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uses new API's from playwright instead of existing puppeteer setup file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace by playwright.global.setup.ts
client/__tests__/util/helpers.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client/playwright.config.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied and pruned from https://github.com/chanzuckerberg/single-cell-data-portal/blob/5f4ee56e1438f47b70765333dc637e5dc9d1fe53/frontend/playwright.config.ts with carry overs from puppeteer config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR comments 🙏 Super helpful!
client/__tests__/common/constants.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good thank you!
@@ -121,17 +117,17 @@ | |||
"@types/lodash.sortby": "^4.7.6", | |||
"@types/lodash.uniq": "^4.5.6", | |||
"@types/lodash.zip": "^4.2.6", | |||
"@types/node": "^20.10.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DP is using Node 20.10.6 starting this PR - do we need to update Explorer side too? chanzuckerberg/single-cell-data-portal#6431
"e2e": "jest --config __tests__/e2e/e2eJestConfig.json e2e/e2e.test.ts", | ||
"e2e-prod": "CXG_URL_BASE='https://cellxgene.cziscience.com/d/pbmc3k.cxg/' jest --config __tests__/e2e/e2eJestConfig.json e2e/e2e.test.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we'll add these back with Playwright in later PRs?
* Install and setup playwright, successfully run example test (#701) * introduce playwright with running example test * cleanup eslint * feat(playwright): migrate tests and e2e utils (#709) * feat(playwright): migrate tests and e2e utils * remove allure * install playwright in workflow * tweak workflow * fix install command * fix mocked endpoints * fix drag and update snapshots * fix scroll related failures * fixes to geneset tests * delete unsued utils * remove more unused * address f/b and fix test * lint * fix tests failing on gha * pass new test * add waits before lasso * all tests passing * fix lint * add new snapshots * skip failing test * always wait for no skeletons * no undo/redo * remove verbose server while running e2e * use cache built into setup-node * skip * revert change to script
* chore(deps-dev): bump follow-redirects from 1.15.2 to 1.15.4 in /client (#702) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(explorer): enable safari fix browser page (#704) * Enable Safari * Fix Supported Browser page * fix image path (#706) * fix(explorer): bundle images (#707) * fix(explorer): bundle images * fix(explorer): enable Safari and fix bundled image path (#708) * fix(explorer): enable Safari and fix bundled image path * test(playwright): Migrate jest + puppeteer to playwright (#714) * Install and setup playwright, successfully run example test (#701) * introduce playwright with running example test * cleanup eslint * feat(playwright): migrate tests and e2e utils (#709) * feat(playwright): migrate tests and e2e utils * remove allure * install playwright in workflow * tweak workflow * fix install command * fix mocked endpoints * fix drag and update snapshots * fix scroll related failures * fixes to geneset tests * delete unsued utils * remove more unused * address f/b and fix test * lint * fix tests failing on gha * pass new test * add waits before lasso * all tests passing * fix lint * add new snapshots * skip failing test * always wait for no skeletons * no undo/redo * remove verbose server while running e2e * use cache built into setup-node * skip * revert change to script --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ronen <kaloster@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>
* chore:staging<-main (#652) * feat: Add a Github Action that automatically closes stale PRs. (#647) * chore: add to software catalog (#649) * fix: override default so that issues are not marked as stale (#650) * chore: update happy config task launch type (#651) --------- Co-authored-by: maniarathi <arathi.mani@chanzuckerberg.com> Co-authored-by: Hayden Spitzley <105455169+hspitzley-czi@users.noreply.github.com> Co-authored-by: Daniel Hegeman <daniel.hegeman@chanzuckerberg.com> * chore: deploy staging <- main (#681) * feat: exclude observation join id from standard and author categories (#674) * exclude observation join id * don't commit package.json changes * add stuff back in * reorder * fix explorer local dev * chore: add script to patch explorer to find portal rdev stack (#671) --------- Co-authored-by: Joyce Yan <5653616+joyceyan@users.noreply.github.com> Co-authored-by: Andrew Tolopko <atolopko-czi@users.noreply.github.com> * chore: main->staging (#721) * chore(deps-dev): bump follow-redirects from 1.15.2 to 1.15.4 in /client (#702) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(explorer): enable safari fix browser page (#704) * Enable Safari * Fix Supported Browser page * fix image path (#706) * fix(explorer): bundle images (#707) * fix(explorer): bundle images * fix(explorer): enable Safari and fix bundled image path (#708) * fix(explorer): enable Safari and fix bundled image path * test(playwright): Migrate jest + puppeteer to playwright (#714) * Install and setup playwright, successfully run example test (#701) * introduce playwright with running example test * cleanup eslint * feat(playwright): migrate tests and e2e utils (#709) * feat(playwright): migrate tests and e2e utils * remove allure * install playwright in workflow * tweak workflow * fix install command * fix mocked endpoints * fix drag and update snapshots * fix scroll related failures * fixes to geneset tests * delete unsued utils * remove more unused * address f/b and fix test * lint * fix tests failing on gha * pass new test * add waits before lasso * all tests passing * fix lint * add new snapshots * skip failing test * always wait for no skeletons * no undo/redo * remove verbose server while running e2e * use cache built into setup-node * skip * revert change to script --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ronen <kaloster@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: maniarathi <arathi.mani@chanzuckerberg.com> Co-authored-by: Hayden Spitzley <105455169+hspitzley-czi@users.noreply.github.com> Co-authored-by: Daniel Hegeman <daniel.hegeman@chanzuckerberg.com> Co-authored-by: prathap sridharan <psridharan@chanzuckerberg.com> Co-authored-by: Joyce Yan <5653616+joyceyan@users.noreply.github.com> Co-authored-by: Andrew Tolopko <atolopko-czi@users.noreply.github.com> Co-authored-by: Emanuele Bezzi <ebezzi@chanzuckerberg.com> Co-authored-by: Nayib Gloria <55710092+nayib-jose-gloria@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ronen <kaloster@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>
* chore(deps-dev): bump follow-redirects from 1.15.2 to 1.15.4 in /client (#702) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... * chore(explorer): enable safari fix browser page (#704) * Enable Safari * Fix Supported Browser page * fix image path (#706) * fix(explorer): bundle images (#707) * fix(explorer): bundle images * fix(explorer): enable Safari and fix bundled image path (#708) * fix(explorer): enable Safari and fix bundled image path * test(playwright): Migrate jest + puppeteer to playwright (#714) * Install and setup playwright, successfully run example test (#701) * introduce playwright with running example test * cleanup eslint * feat(playwright): migrate tests and e2e utils (#709) * feat(playwright): migrate tests and e2e utils * remove allure * install playwright in workflow * tweak workflow * fix install command * fix mocked endpoints * fix drag and update snapshots * fix scroll related failures * fixes to geneset tests * delete unsued utils * remove more unused * address f/b and fix test * lint * fix tests failing on gha * pass new test * add waits before lasso * all tests passing * fix lint * add new snapshots * skip failing test * always wait for no skeletons * no undo/redo * remove verbose server while running e2e * use cache built into setup-node * skip * revert change to script --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Trent Smith <1429913+Bento007@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ronen <kaloster@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>
This is a breaking change to the current test suite, the existing tests still need to be migrated onto playwright. All e2e GHA will be failing as a result.
To test:
npm install and run the following command