Install and setup playwright, successfully run example test #701

seve · 2024-01-09T18:14:39Z

This is a breaking change to the current test suite, the existing tests still need to be migrated onto playwright. All e2e GHA will be failing as a result.

To test:

npm install and run the following command

npx playwright test __tests__/example.spec.ts

seve · 2024-01-09T18:15:35Z

client/__tests__/common/constants.ts

some of these constants may be pruned at the end of the migration, I will run a JS util to see what exports are not being imported/used anywhere

Sounds good thank you!

seve · 2024-01-09T18:17:09Z

client/__tests__/common/playwrightContext.ts

direct copy from:
https://github.com/chanzuckerberg/single-cell-data-portal/blob/5f4ee56e1438f47b70765333dc637e5dc9d1fe53/frontend/tests/common/context.ts

codecov · 2024-01-09T18:17:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80fc7c6) 77.67% compared to head (487eae2) 77.67%.

❗ Current head 487eae2 differs from pull request most recent head d098db2. Consider uploading reports for the commit d098db2 to get more accurate results

Additional details and impacted files

@@               Coverage Diff                @@
##           feat-playwright     #701   +/-   ##
================================================
  Coverage            77.67%   77.67%           
================================================
  Files                   88       88           
  Lines                 6772     6772           
================================================
  Hits                  5260     5260           
  Misses                1512     1512

Flag	Coverage Δ
frontend	`77.67% <ø> (ø)`
javascript	`77.67% <ø> (ø)`
smokeTest	`?`
unitTest	`77.67% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

seve · 2024-01-09T18:17:57Z

client/__tests__/e2e/playwright.global.setup.ts

Uses new API's from playwright instead of existing puppeteer setup file

seve · 2024-01-09T18:18:12Z

client/__tests__/e2e/puppeteer.setup.ts

replace by playwright.global.setup.ts

seve · 2024-01-09T18:18:43Z

client/__tests__/util/helpers.ts

Copied and pruned from https://github.com/chanzuckerberg/single-cell-data-portal/blob/5f4ee56e1438f47b70765333dc637e5dc9d1fe53/frontend/tests/utils/helpers.ts

seve · 2024-01-09T18:19:52Z

client/playwright.config.ts

Copied and pruned from https://github.com/chanzuckerberg/single-cell-data-portal/blob/5f4ee56e1438f47b70765333dc637e5dc9d1fe53/frontend/playwright.config.ts with carry overs from puppeteer config

tihuan

LGTM! Thanks for the PR comments 🙏 Super helpful!

tihuan · 2024-01-09T19:05:09Z

client/__tests__/common/constants.ts

Sounds good thank you!

tihuan · 2024-01-09T19:06:58Z

client/package.json

@@ -121,17 +117,17 @@
    "@types/lodash.sortby": "^4.7.6",
    "@types/lodash.uniq": "^4.5.6",
    "@types/lodash.zip": "^4.2.6",
+    "@types/node": "^20.10.6",


DP is using Node 20.10.6 starting this PR - do we need to update Explorer side too? chanzuckerberg/single-cell-data-portal#6431

tihuan · 2024-01-09T19:07:26Z

client/package.json

-    "e2e": "jest --config __tests__/e2e/e2eJestConfig.json e2e/e2e.test.ts",
-    "e2e-prod": "CXG_URL_BASE='https://cellxgene.cziscience.com/d/pbmc3k.cxg/' jest --config __tests__/e2e/e2eJestConfig.json e2e/e2e.test.ts",


I assume we'll add these back with Playwright in later PRs?

…ight

* Install and setup playwright, successfully run example test (#701) * introduce playwright with running example test * cleanup eslint * feat(playwright): migrate tests and e2e utils (#709) * feat(playwright): migrate tests and e2e utils * remove allure * install playwright in workflow * tweak workflow * fix install command * fix mocked endpoints * fix drag and update snapshots * fix scroll related failures * fixes to geneset tests * delete unsued utils * remove more unused * address f/b and fix test * lint * fix tests failing on gha * pass new test * add waits before lasso * all tests passing * fix lint * add new snapshots * skip failing test * always wait for no skeletons * no undo/redo * remove verbose server while running e2e * use cache built into setup-node * skip * revert change to script

* chore(deps-dev): bump follow-redirects from 1.15.2 to 1.15.4 in /client (#702) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(explorer): enable safari fix browser page (#704) * Enable Safari * Fix Supported Browser page * fix image path (#706) * fix(explorer): bundle images (#707) * fix(explorer): bundle images * fix(explorer): enable Safari and fix bundled image path (#708) * fix(explorer): enable Safari and fix bundled image path * test(playwright): Migrate jest + puppeteer to playwright (#714) * Install and setup playwright, successfully run example test (#701) * introduce playwright with running example test * cleanup eslint * feat(playwright): migrate tests and e2e utils (#709) * feat(playwright): migrate tests and e2e utils * remove allure * install playwright in workflow * tweak workflow * fix install command * fix mocked endpoints * fix drag and update snapshots * fix scroll related failures * fixes to geneset tests * delete unsued utils * remove more unused * address f/b and fix test * lint * fix tests failing on gha * pass new test * add waits before lasso * all tests passing * fix lint * add new snapshots * skip failing test * always wait for no skeletons * no undo/redo * remove verbose server while running e2e * use cache built into setup-node * skip * revert change to script --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ronen <kaloster@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>

* chore:staging<-main (#652) * feat: Add a Github Action that automatically closes stale PRs. (#647) * chore: add to software catalog (#649) * fix: override default so that issues are not marked as stale (#650) * chore: update happy config task launch type (#651) --------- Co-authored-by: maniarathi <arathi.mani@chanzuckerberg.com> Co-authored-by: Hayden Spitzley <105455169+hspitzley-czi@users.noreply.github.com> Co-authored-by: Daniel Hegeman <daniel.hegeman@chanzuckerberg.com> * chore: deploy staging <- main (#681) * feat: exclude observation join id from standard and author categories (#674) * exclude observation join id * don't commit package.json changes * add stuff back in * reorder * fix explorer local dev * chore: add script to patch explorer to find portal rdev stack (#671) --------- Co-authored-by: Joyce Yan <5653616+joyceyan@users.noreply.github.com> Co-authored-by: Andrew Tolopko <atolopko-czi@users.noreply.github.com> * chore: main->staging (#721) * chore(deps-dev): bump follow-redirects from 1.15.2 to 1.15.4 in /client (#702) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(explorer): enable safari fix browser page (#704) * Enable Safari * Fix Supported Browser page * fix image path (#706) * fix(explorer): bundle images (#707) * fix(explorer): bundle images * fix(explorer): enable Safari and fix bundled image path (#708) * fix(explorer): enable Safari and fix bundled image path * test(playwright): Migrate jest + puppeteer to playwright (#714) * Install and setup playwright, successfully run example test (#701) * introduce playwright with running example test * cleanup eslint * feat(playwright): migrate tests and e2e utils (#709) * feat(playwright): migrate tests and e2e utils * remove allure * install playwright in workflow * tweak workflow * fix install command * fix mocked endpoints * fix drag and update snapshots * fix scroll related failures * fixes to geneset tests * delete unsued utils * remove more unused * address f/b and fix test * lint * fix tests failing on gha * pass new test * add waits before lasso * all tests passing * fix lint * add new snapshots * skip failing test * always wait for no skeletons * no undo/redo * remove verbose server while running e2e * use cache built into setup-node * skip * revert change to script --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ronen <kaloster@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: maniarathi <arathi.mani@chanzuckerberg.com> Co-authored-by: Hayden Spitzley <105455169+hspitzley-czi@users.noreply.github.com> Co-authored-by: Daniel Hegeman <daniel.hegeman@chanzuckerberg.com> Co-authored-by: prathap sridharan <psridharan@chanzuckerberg.com> Co-authored-by: Joyce Yan <5653616+joyceyan@users.noreply.github.com> Co-authored-by: Andrew Tolopko <atolopko-czi@users.noreply.github.com> Co-authored-by: Emanuele Bezzi <ebezzi@chanzuckerberg.com> Co-authored-by: Nayib Gloria <55710092+nayib-jose-gloria@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ronen <kaloster@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>

* chore(deps-dev): bump follow-redirects from 1.15.2 to 1.15.4 in /client (#702) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... * chore(explorer): enable safari fix browser page (#704) * Enable Safari * Fix Supported Browser page * fix image path (#706) * fix(explorer): bundle images (#707) * fix(explorer): bundle images * fix(explorer): enable Safari and fix bundled image path (#708) * fix(explorer): enable Safari and fix bundled image path * test(playwright): Migrate jest + puppeteer to playwright (#714) * Install and setup playwright, successfully run example test (#701) * introduce playwright with running example test * cleanup eslint * feat(playwright): migrate tests and e2e utils (#709) * feat(playwright): migrate tests and e2e utils * remove allure * install playwright in workflow * tweak workflow * fix install command * fix mocked endpoints * fix drag and update snapshots * fix scroll related failures * fixes to geneset tests * delete unsued utils * remove more unused * address f/b and fix test * lint * fix tests failing on gha * pass new test * add waits before lasso * all tests passing * fix lint * add new snapshots * skip failing test * always wait for no skeletons * no undo/redo * remove verbose server while running e2e * use cache built into setup-node * skip * revert change to script --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Trent Smith <1429913+Bento007@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ronen <kaloster@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>

introduce playwright with running example test

8a289c8

seve requested review from tihuan and atarashansky January 9, 2024 18:14

seve linked an issue Jan 9, 2024 that may be closed by this pull request

Install and setup Playwright #693

Closed

3 tasks

seve commented Jan 9, 2024

View reviewed changes

client/__tests__/e2e/puppeteer.setup.ts Outdated

Copy link

Contributor Author

seve Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace by playwright.global.setup.ts

seve commented Jan 9, 2024

View reviewed changes

cleanup eslint

487eae2

tihuan approved these changes Jan 9, 2024

View reviewed changes

seve changed the base branch from main to feat-playwright January 18, 2024 22:01

Merge branch 'feat-playwright' into seve/693-install-and-setup-playwr…

d098db2

…ight

seve merged commit e1d2931 into feat-playwright Jan 18, 2024
1 of 3 checks passed

seve deleted the seve/693-install-and-setup-playwright branch January 18, 2024 22:05

seve mentioned this pull request Jan 24, 2024

test(playwright): Migrate jest + puppeteer to playwright #714

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Install and setup playwright, successfully run example test #701

Install and setup playwright, successfully run example test #701

seve commented Jan 9, 2024

seve Jan 9, 2024

tihuan Jan 9, 2024

seve Jan 9, 2024

codecov bot commented Jan 9, 2024 •

edited

Loading

seve Jan 9, 2024

seve Jan 9, 2024

seve Jan 9, 2024

seve Jan 9, 2024

tihuan left a comment

tihuan Jan 9, 2024

tihuan Jan 9, 2024

tihuan Jan 9, 2024

		"e2e": "jest --config __tests__/e2e/e2eJestConfig.json e2e/e2e.test.ts",
		"e2e-prod": "CXG_URL_BASE='https://cellxgene.cziscience.com/d/pbmc3k.cxg/' jest --config __tests__/e2e/e2eJestConfig.json e2e/e2e.test.ts",

Install and setup playwright, successfully run example test #701

Install and setup playwright, successfully run example test #701

Conversation

seve commented Jan 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jan 9, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tihuan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jan 9, 2024 •

edited

Loading