Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a Github Action that automatically closes stale PRs. #647

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

maniarathi
Copy link
Contributor

Reason for Change

As we move to CI/CD, some automation can help ensure that we're working towards trunk-based development and ensuring that non-draft PRs don't stay open too long without some movement. Ideally, this Github Action helps us with a few things:

  1. PRs remain small so that they can be reviewed quickly and merged.
  2. If a PR has be alive for more than 2 weeks, updates are required so that there is visibility as to why the PR is blocked.
  3. If the PR has to be alive for more than 2 weeks and is blocked, it reverts to being a draft PR or closed.

Ticket Number

No ticket.

Changes

Additions

Add a Github Action that runs daily. Each day all active (non-draft) PRs older than 2 weeks are marked with a stale tag and a warning comment is made to update the PR. In another 3 days (3 days was chosen to accommodate long weekends + 1 day), the PR will be automatically closed.

Deletions

None.

Modifications

None.

Testing steps

Not tested.

Notes for Reviewer

None.

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #647 (e0c7efb) into main (2a8496f) will not change coverage.
The diff coverage is n/a.

❗ Current head e0c7efb differs from pull request most recent head 8df9f19. Consider uploading reports for the commit 8df9f19 to get more accurate results

@@           Coverage Diff           @@
##             main     #647   +/-   ##
=======================================
  Coverage   77.67%   77.67%           
=======================================
  Files          88       88           
  Lines        6754     6754           
=======================================
  Hits         5246     5246           
  Misses       1508     1508           
Flag Coverage Δ
frontend 77.67% <ø> (ø)
javascript 77.67% <ø> (ø)
smokeTest ?
unitTest 77.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maniarathi maniarathi merged commit f15b4db into main Aug 21, 2023
3 checks passed
@maniarathi maniarathi deleted the maniarathi/close-stale-prs branch August 21, 2023 20:37
Bento007 added a commit that referenced this pull request Sep 12, 2023
* feat: Add a Github Action that automatically closes stale PRs. (#647)

* chore: add to software catalog (#649)

* fix: override default so that issues are not marked as stale (#650)

* chore: update happy config task launch type (#651)

---------

Co-authored-by: maniarathi <arathi.mani@chanzuckerberg.com>
Co-authored-by: Hayden Spitzley <105455169+hspitzley-czi@users.noreply.github.com>
Co-authored-by: Daniel Hegeman <daniel.hegeman@chanzuckerberg.com>
Bento007 added a commit that referenced this pull request Sep 14, 2023
* feat: Add a Github Action that automatically closes stale PRs. (#647)

* chore: add to software catalog (#649)

* fix: override default so that issues are not marked as stale (#650)

* chore: update happy config task launch type (#651)

---------

Co-authored-by: maniarathi <arathi.mani@chanzuckerberg.com>
Co-authored-by: Hayden Spitzley <105455169+hspitzley-czi@users.noreply.github.com>
Co-authored-by: Daniel Hegeman <daniel.hegeman@chanzuckerberg.com>
Bento007 added a commit that referenced this pull request Jan 25, 2024
* chore:staging<-main (#652)

* feat: Add a Github Action that automatically closes stale PRs. (#647)

* chore: add to software catalog (#649)

* fix: override default so that issues are not marked as stale (#650)

* chore: update happy config task launch type (#651)

---------

Co-authored-by: maniarathi <arathi.mani@chanzuckerberg.com>
Co-authored-by: Hayden Spitzley <105455169+hspitzley-czi@users.noreply.github.com>
Co-authored-by: Daniel Hegeman <daniel.hegeman@chanzuckerberg.com>

* chore: deploy staging <- main (#681)

* feat: exclude observation join id from standard and author categories (#674)

* exclude observation join id

* don't commit package.json changes

* add stuff back in

* reorder

* fix explorer local dev

* chore: add script to patch explorer to find portal rdev stack (#671)

---------

Co-authored-by: Joyce Yan <5653616+joyceyan@users.noreply.github.com>
Co-authored-by: Andrew Tolopko <atolopko-czi@users.noreply.github.com>

* chore: main->staging (#721)

* chore(deps-dev): bump follow-redirects from 1.15.2 to 1.15.4 in /client (#702)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(explorer): enable safari fix browser page (#704)

* Enable Safari
* Fix Supported Browser page

* fix image path (#706)

* fix(explorer): bundle images (#707)

* fix(explorer): bundle images

* fix(explorer): enable Safari and fix bundled image path (#708)

* fix(explorer): enable Safari and fix bundled image path

* test(playwright): Migrate jest + puppeteer to playwright (#714)

* Install and setup playwright, successfully run example test (#701)

* introduce playwright with running example test

* cleanup eslint

* feat(playwright): migrate tests and e2e utils (#709)

* feat(playwright): migrate tests and e2e utils

* remove allure

* install playwright in workflow

* tweak workflow

* fix install command

* fix mocked endpoints

* fix drag and update snapshots

* fix scroll related failures

* fixes to geneset tests

* delete unsued utils

* remove more unused

* address f/b and fix test

* lint

* fix tests failing on gha

* pass new test

* add waits before lasso

* all tests passing

* fix lint

* add new snapshots

* skip failing test

* always wait for no skeletons

* no undo/redo

* remove verbose server while running e2e

* use cache built into setup-node

* skip

* revert change to script

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ronen <kaloster@users.noreply.github.com>
Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: maniarathi <arathi.mani@chanzuckerberg.com>
Co-authored-by: Hayden Spitzley <105455169+hspitzley-czi@users.noreply.github.com>
Co-authored-by: Daniel Hegeman <daniel.hegeman@chanzuckerberg.com>
Co-authored-by: prathap sridharan <psridharan@chanzuckerberg.com>
Co-authored-by: Joyce Yan <5653616+joyceyan@users.noreply.github.com>
Co-authored-by: Andrew Tolopko <atolopko-czi@users.noreply.github.com>
Co-authored-by: Emanuele Bezzi <ebezzi@chanzuckerberg.com>
Co-authored-by: Nayib Gloria <55710092+nayib-jose-gloria@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ronen <kaloster@users.noreply.github.com>
Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants