Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 5795 Upgrade node LTM version #6431

Merged
merged 5 commits into from
Jan 11, 2024
Merged

chore: 5795 Upgrade node LTM version #6431

merged 5 commits into from
Jan 11, 2024

Conversation

tihuan
Copy link
Contributor

@tihuan tihuan commented Jan 8, 2024

Reason for Change

⚠️⚠️⚠️ ACTION REQUESTED ⚠️⚠️⚠️

  1. To run npm run dev properly, you may need to run npm rebuild after this PR is merged into main

Changes

  1. Update Node version from 16.14.2 to 20.10.0 (the current LTM)
  2. Update its corresponding type file and fix some type issues caused by TypeScript defaulting to NodeJS' API instead of DOM's equivalents, which is what we actually want

Testing steps

  1. The whole app should work as intended. Since this is a node related upgrade, it shouldn't affect client side runtime in the browser but mostly server side runtime and build time
  2. I've checked server side rendering, app obviously builds for both dev and prod modes, and npm i works for me

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Deployment Summary

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6616d1a) 92.11% compared to head (6222dcd) 92.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6431   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files         179      179           
  Lines       14805    14805           
=======================================
  Hits        13638    13638           
  Misses       1167     1167           
Flag Coverage Δ
unittests 92.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tihuan tihuan force-pushed the thuang-5795-upgrade-node branch 2 times, most recently from c66ee3a to 0a183a9 Compare January 8, 2024 21:12
@tihuan
Copy link
Contributor Author

tihuan commented Jan 8, 2024

WMG rdev BE is currently down, thus e2e tests are failing

@tihuan
Copy link
Contributor Author

tihuan commented Jan 9, 2024

All tests should be passing now 💯

@tihuan tihuan merged commit f094b97 into main Jan 11, 2024
40 checks passed
@tihuan tihuan deleted the thuang-5795-upgrade-node branch January 11, 2024 16:21
@tihuan
Copy link
Contributor Author

tihuan commented Jan 11, 2024

Thanks so much for rerunning the GHA for me, @kaloster 🙏 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants