-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: skip e2e if feature disabled #1114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchu1
reviewed
Sep 5, 2024
bchu1
approved these changes
Sep 5, 2024
github-actions bot
added a commit
that referenced
this pull request
Sep 5, 2024
🤖 I have created a release *beep* *boop* --- ## [1.26.0](web-v1.25.0...web-v1.26.0) (2024-09-05) ### ✨ Features * add deposition related filters ([#1079](#1079)) ([ffec095](ffec095)) * Add metadata sidebar for tomogram ([#1112](#1112)) ([39351f0](39351f0)) * Add Tomograms Summary to run sidebar ([#1094](#1094)) ([5a3132a](5a3132a)) * deposition filter banner ([#1040](#1040)) ([bb83312](bb83312)) * info panel deposition metadata ([#1092](#1092)) ([01a8b67](01a8b67)) * Make main photo HTML and CSS consistent between run and dataset pages ([#1096](#1096)) ([6a88242](6a88242)) * More updates to tomograms table ([#1106](#1106)) ([a6ef66e](a6ef66e)) * View Tomogram tooltips + button changes ([#1089](#1089)) ([54b4fe5](54b4fe5)) ### 🐞 Bug Fixes * Carry over filters from datasets table ([#1113](#1113)) ([b3c8628](b3c8628)) * Disable Apollo Client cache on the server ([#1088](#1088)) ([373b987](373b987)), closes [#1041](#1041) ### ⚙ Continuous Integration * add missing skip e2e ([#1116](#1116)) ([ee6064a](ee6064a)) * skip e2e if feature disabled ([#1114](#1114)) ([b5cb014](b5cb014)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kne42
added a commit
that referenced
this pull request
Sep 11, 2024
* main: feat: Implement new single tomogram download flow (#1120) fix: header key photo sizing (#1117) feat: Id prefixes in filters (#1124) chore(main): release web 1.26.1 (#1122) chore: Leave comments about not refactoring pagination tests (#1121) docs: Move documentation site to Sphinx Immaterial (#1087) chore(main): release web 1.26.0 (#1084) ci: add missing skip e2e (#1116) feat: Add metadata sidebar for tomogram (#1112) ci: skip e2e if feature disabled (#1114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new util function to skip e2e tests if a certain feature is not enabled. This should also fix the prod E2Es that have been failing for a bit