Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQL responses are cached "forever" in the frontend server #1041

Closed
bchu1 opened this issue Aug 19, 2024 · 0 comments · Fixed by #1088 or #1084
Closed

GQL responses are cached "forever" in the frontend server #1041

bchu1 opened this issue Aug 19, 2024 · 0 comments · Fixed by #1088 or #1084
Assignees
Labels
bug Something isn't working frontend severity - high impacts a large portion of the Portal’s features and functionality, with no clear workaround

Comments

@bchu1
Copy link
Contributor

bchu1 commented Aug 19, 2024

Describe the bug
(there might be disagreement on the extent to which this is a bug)

Right now it seems the Apollo client on the frontend server is caching every query such that if the underlying data changes (before the next deploy), the UI still gets the same data.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any data page
  2. Update some data
  3. Refresh
  4. Nothing changed

Additional context
It seems disabling the Apollo cache fixes this

defaultOptions: {
    query: {
      fetchPolicy: 'no-cache',
    },
  }

Disabling ssrMode and using network-only also works (though only useful if we intend to actually use the cache)

ssrMode: false,
  defaultOptions: {
    query: {
      fetchPolicy: 'network-only',
    },
  }
@bchu1 bchu1 added the bug Something isn't working label Aug 19, 2024
@junxini junxini added the severity - high impacts a large portion of the Portal’s features and functionality, with no clear workaround label Aug 21, 2024
@junxini junxini added this to the sprint 3 (phase 4) milestone Aug 22, 2024
@bchu1 bchu1 closed this as completed in 373b987 Sep 3, 2024
github-actions bot added a commit that referenced this issue Sep 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.26.0](web-v1.25.0...web-v1.26.0)
(2024-09-05)


### ✨ Features

* add deposition related filters
([#1079](#1079))
([ffec095](ffec095))
* Add metadata sidebar for tomogram
([#1112](#1112))
([39351f0](39351f0))
* Add Tomograms Summary to run sidebar
([#1094](#1094))
([5a3132a](5a3132a))
* deposition filter banner
([#1040](#1040))
([bb83312](bb83312))
* info panel deposition metadata
([#1092](#1092))
([01a8b67](01a8b67))
* Make main photo HTML and CSS consistent between run and dataset pages
([#1096](#1096))
([6a88242](6a88242))
* More updates to tomograms table
([#1106](#1106))
([a6ef66e](a6ef66e))
* View Tomogram tooltips + button changes
([#1089](#1089))
([54b4fe5](54b4fe5))


### 🐞 Bug Fixes

* Carry over filters from datasets table
([#1113](#1113))
([b3c8628](b3c8628))
* Disable Apollo Client cache on the server
([#1088](#1088))
([373b987](373b987)),
closes
[#1041](#1041)


### ⚙ Continuous Integration

* add missing skip e2e
([#1116](#1116))
([ee6064a](ee6064a))
* skip e2e if feature disabled
([#1114](#1114))
([b5cb014](b5cb014))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend severity - high impacts a large portion of the Portal’s features and functionality, with no clear workaround
Projects
None yet
3 participants