feat: deposition filter banner #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
changed the title
bchu1
reviewed
Aug 20, 2024
frontend/packages/data-portal/app/components/Dataset/RunsTable.tsx
Outdated
Show resolved
Hide resolved
bchu1
reviewed
Aug 20, 2024
kne42
reviewed
Aug 20, 2024
codemonkey800
force-pushed
the
jeremy/deposition-filter-banner
branch
from
2a4c4ba
to
1059417
Compare
bchu1
reviewed
Aug 21, 2024
| @@ -61,6 +63,25 @@ export function RunsTable() { | |||
| [searchParams, setSingleDatasetHistory], | |||
| ) | |||
|
|
|||
| const getRunUrl = useCallback( | |||
| (id: number) => { | |||
| const url = createUrl(`/runs/${id}`) | |||
There was a problem hiding this comment.
nit - since we're only using the path and the query params, do we need createUrl()? what if carryOverFilterParams() just returned a new URLSearchParams and we did return `/runs/${id}\` + urlSearchParams.toString()?
There was a problem hiding this comment.
I tend to prefer modifying the URL and URLSearchParams objects directly to avoid direct string concatenation, so createUrl() is helpful here since we're only using the pathname and params
bchu1
reviewed
Aug 21, 2024
bchu1
approved these changes
Aug 21, 2024
|
Another thought - now that we have the deposition ID in the URL params, should we just consolidate the previous deposition state into the query param? Unless there's a situation where we'd only want one of either the back to deposition button or the filter banner... |
codemonkey800
force-pushed
the
jeremy/deposition-filter-banner
branch
from
664afa9
to
02b04c3
Compare
|
@Janeece it should be fixed now, could you take a look again when you get a chance please 🙏 |
Janeece
approved these changes
Aug 28, 2024
github-actions bot
added a commit
that referenced
this pull request
Sep 5, 2024
🤖 I have created a release *beep* *boop* --- ## [1.26.0](web-v1.25.0...web-v1.26.0) (2024-09-05) ### ✨ Features * add deposition related filters ([#1079](#1079)) ([ffec095](ffec095)) * Add metadata sidebar for tomogram ([#1112](#1112)) ([39351f0](39351f0)) * Add Tomograms Summary to run sidebar ([#1094](#1094)) ([5a3132a](5a3132a)) * deposition filter banner ([#1040](#1040)) ([bb83312](bb83312)) * info panel deposition metadata ([#1092](#1092)) ([01a8b67](01a8b67)) * Make main photo HTML and CSS consistent between run and dataset pages ([#1096](#1096)) ([6a88242](6a88242)) * More updates to tomograms table ([#1106](#1106)) ([a6ef66e](a6ef66e)) * View Tomogram tooltips + button changes ([#1089](#1089)) ([54b4fe5](54b4fe5)) ### 🐞 Bug Fixes * Carry over filters from datasets table ([#1113](#1113)) ([b3c8628](b3c8628)) * Disable Apollo Client cache on the server ([#1088](#1088)) ([373b987](373b987)), closes [#1041](#1041) ### ⚙ Continuous Integration * add missing skip e2e ([#1116](#1116)) ([ee6064a](ee6064a)) * skip e2e if feature disabled ([#1114](#1114)) ([b5cb014](b5cb014)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#925
deposition-idbanner?: ReactNodeto render banner at the top of<TablePageLayout />Demos
https://dev-depo-filter-banner.cryoet.dev.si.czi.technology/
Dataset Page
Run Page