Work out a new way to write integration tests #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhchabran
changed the title
asdine
reviewed
Apr 10, 2021
cmd/examplar/main.go
Outdated
| } | ||
|
|
||
| paths := os.Args[2:] | ||
| fmt.Println(paths) |
jhchabran
commented
Apr 10, 2021
jhchabran
commented
Apr 10, 2021
Codecov Report
@@ Coverage Diff @@
## main #380 +/- ##
==========================================
+ Coverage 68.15% 68.40% +0.24%
==========================================
Files 74 77 +3
Lines 7367 7650 +283
==========================================
+ Hits 5021 5233 +212
- Misses 1679 1739 +60
- Partials 667 678 +11
Continue to review full report at Codecov.
|
asdine
approved these changes
Apr 13, 2021
| defer db.Close() | ||
|
|
||
| // query results wrapper | ||
| jsonResult := func(t *testing.T, res *query.Result) []byte { |
There was a problem hiding this comment.
⏲️ This can be replaced by:
var buf bytes.Buffer
err = document.IteratorToJSONArray(&buf, res)
return buf.Bytes()
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And possibly GitHub issues, when we'll have iterated enough on it :)
➡️ check the README for an extensive description of what it does and how it works.
To avoid messing with paths (the test template), it uses
embedfrom Go 1.16. It can be an issue, and it could be fixed if needed.