Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiline comment #394

Closed
jhchabran opened this issue May 3, 2021 · 2 comments
Closed

Add support for multiline comment #394

jhchabran opened this issue May 3, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@jhchabran
Copy link
Collaborator

After having experimented a bit with a simpler way to write integration tests (see #380), it has become apparent that the single-line comments can get in the way of writing the expectations, especially with the alignment.

Multiline comments would enable to address that specific point.

It is quite common (https://www.sqlite.org/lang_comment.html) to have those defined as /* ... */.

@jhchabran jhchabran added the enhancement New feature or request label May 3, 2021
@jhchabran
Copy link
Collaborator Author

Closing this, they're already supported as per https://github.com/genjidb/genji/blob/main/sql/scanner/scanner.go#L134-L139

genji> select /* trololollo */ 1+1;
{
  "1+1": 2
}
genji>

@asdine
Copy link
Collaborator

asdine commented May 4, 2021

I had completely forgotten that we already had multi-line comments 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants