Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added legacy support change and submit events in ie 6/7/8 #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added legacy support change and submit events in ie 6/7/8 #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions plugins/gator-legacy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,28 @@
type = 'focusout';
}

if (type == 'change') {
gator.element.attachEvent('onfocusin', function(){
_legacyAttach(type, window.event.srcElement, callback)
});
}

if (type == 'submit') {
gator.element.attachEvent('onfocusin', function(){
_legacyAttach(type, window.event.srcElement.form, callback)
});
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a bit odd that you're attaching three events here, you have line 37, line 42, and the later, line 47. Can you explain further what's going on here? Some comments would help.


gator.element.attachEvent('on' + type, callback);
};

function _legacyAttach(type, element, callback) {
if(element && !element.getAttribute('data-gator-attached')) {
element.attachEvent('on' + type, callback);
element.setAttribute('data-gator-attached','true');
}
}

Gator.matchesSelector = function(selector) {

// check for class name
Expand Down