added legacy support change and submit events in ie 6/7/8 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ccampbell How about pulling these changes? |
|
+1 |
| gator.element.attachEvent('onfocusin', function(){ | ||
| _legacyAttach(type, window.event.srcElement.form, callback) | ||
| }); | ||
| } |
There was a problem hiding this comment.
It seems a bit odd that you're attaching three events here, you have line 37, line 42, and the later, line 47. Can you explain further what's going on here? Some comments would help.
|
Dang, this project really needs tests. This particular PR would really benefit from a test that shows the problem and its fix. |
|
Haha @lazd I totally agree. It's just a time thing |
|
@ccampbell sounds like a familiar struggle :) I reviewed a few PRs, filed some issues, and commented on a few things to get the conversation going again. I'll see what I can do about fixing a few things if you can get us caught up on existing issues and PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix for issue #7. It adds support for change and submit events in legacy ie browsers which don't support event bubbling on them. It uses a simple trick by catching the first focus event on the element and then attaching the callback to the correct event.