Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app crashes after autofocus of LNURL amount input. Define bugsnag component outside of app component to avoid subtree's DOM nodes and states beeing destroyed #52

Merged
merged 14 commits into from
Jun 14, 2023
Merged

Fix app crashes after autofocus of LNURL amount input. Define bugsnag component outside of app component to avoid subtree's DOM nodes and states beeing destroyed #52

merged 14 commits into from
Jun 14, 2023

Conversation

KKA11010
Copy link
Collaborator

No description provided.

@KKA11010
fix app crash after auto focus LNURL input
d5a6a23
@KKA11010
Do not define components during render. React will destroy the entire…
de073ea 
… subtree’s DOM nodes and state. Instead, move this component definition out of the parent component “App” and pass data as props.
@KKA11010
remove prop private from pkg.json
d6fd0a3
@KKA11010
Merge branch 'main' into sonar-lint
32aea4c
@KKA11010 KKA11010 added the bug Something isn't working label Jun 11, 2023
@KKA11010 KKA11010 added this to the First Beta Release milestone Jun 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2023 •
edited

Codecov Report

Patch coverage: 2.81% and project coverage change: +0.09 🎉

Comparison is base (0dc9d3a) 20.30% compared to head (1d106e5) 20.39%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   20.30%   20.39%   +0.09%     
==========================================
  Files          84       84              
  Lines        3034     3025       -9     
  Branches      811      809       -2     
==========================================
+ Hits          616      617       +1     
+ Misses       2357     2346      -11     
- Partials       61       62       +1
Impacted Files Coverage Δ
src/components/App.tsx 0.00% <0.00%> (ø)
src/components/ErrorScreen/ErrorDetails.tsx 0.00% <0.00%> (ø)
src/components/InvoiceAmount.tsx 0.00% <0.00%> (ø)
src/components/nav/CustomDrawer.tsx 0.00% <ø> (ø)
src/components/pages/History/Details.tsx 0.00% <0.00%> (ø)
src/components/pages/Lightning/modal.tsx 0.00% <0.00%> (ø)
src/components/pages/Lightning/pageContent.tsx 0.00% <0.00%> (ø)
src/components/pages/Lightning/payInvoice.tsx 0.00% <0.00%> (ø)
src/components/pages/Lightning/scannedQR.tsx 0.00% <0.00%> (ø)
src/components/pages/Mints/IntermintSwap.tsx 0.00% <0.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

BilligsterUser
BilligsterUser suggested changes Jun 11, 2023
View reviewed changes
src/wallet/index.ts Outdated Show resolved Hide resolved
BilligsterUser
BilligsterUser suggested changes Jun 11, 2023
View reviewed changes
config/app.config.ts Outdated Show resolved Hide resolved
@KKA11010 KKA11010 marked this pull request as draft June 12, 2023 09:29
@KKA11010 KKA11010 marked this pull request as ready for review June 12, 2023 11:57
BilligsterUser
BilligsterUser suggested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@BilligsterUser BilligsterUser left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions @KKA11010

src/wallet/index.ts Show resolved Hide resolved
src/components/nav/CustomDrawer.tsx Outdated Show resolved Hide resolved
src/components/App.tsx Show resolved Hide resolved
app.config.js Outdated Show resolved Hide resolved
@BilligsterUser
Copy link
Contributor

Thx for the 2 left Things i need about 2 hours to Run some tests

BilligsterUser
BilligsterUser suggested changes Jun 14, 2023
View reviewed changes
src/util/index.ts Show resolved Hide resolved
@KKA11010
Copy link
Collaborator Author

Fixes #55, Fixes #54

BilligsterUser
BilligsterUser approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@BilligsterUser BilligsterUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BilligsterUser BilligsterUser merged commit 440d26a into main Jun 14, 2023
3 checks passed
@BilligsterUser BilligsterUser deleted the sonar-lint branch June 14, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BilligsterUser BilligsterUser BilligsterUser approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
First Beta Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KKA11010 @codecov-commenter @BilligsterUser