Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linking canOpenUrl returns false for url-schemes that are not included in the AndroidManifest.xml #53

Closed
KKA11010 opened this issue Jun 11, 2023 · 1 comment
Closed

Linking canOpenUrl returns false for url-schemes that are not included in the AndroidManifest.xml #53

KKA11010 opened this issue Jun 11, 2023 · 1 comment
Assignees
@KKA11010
Labels
Android Android related issues bug Something isn't working
Milestone
First Beta Release

Comments

@KKA11010
Copy link
Collaborator

Requires editing Manifest in Expo managed repos to allow url-schemes like "lightning:".

https://stackoverflow.com/questions/64699801/linking-canopenurl-returning-false-when-targeting-android-30-sdk-on-react-native
@KKA11010 KKA11010 added bug Something isn't working Android Android related issues labels Jun 11, 2023
@KKA11010 KKA11010 added this to the First Beta Release milestone Jun 11, 2023
KKA11010 added a commit that referenced this issue Jun 11, 2023
@KKA11010
update openUrl function (provisionally) #53
3704b0e
BilligsterUser pushed a commit that referenced this issue Jun 14, 2023
@KKA11010
Fix app crashes after autofocus of LNURL amount input. Define bugsnag…
440d26a 
… component outside of app component to avoid subtree's DOM nodes and states beeing destroyed (#52)

* fix app crash after auto focus LNURL input

* Do not define components during render. React will destroy the entire subtree’s DOM nodes and state. Instead, move this component definition out of the parent component “App” and pass data as props.

* remove prop private from pkg.json

* update after review

* update after review

* update openUrl function (provisionally) #53

* update after review

* update wrong imports, update errorBoundary component. Fixes #54

* lint

* reset asset paths in app.config

* update after review

* Fixes #55 Minting sats should not allow decimal entry

* update after review
@BilligsterUser BilligsterUser removed their assignment Jun 16, 2023
@KKA11010
Copy link
Collaborator Author

@BilligsterUser I think this can be closed as soon as the try_catch has been tested on a build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KKA11010 KKA11010

Labels
Android Android related issues bug Something isn't working
Projects
None yet
Milestone
First Beta Release
Development

No branches or pull requests
2 participants
@KKA11010 @BilligsterUser