-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a runtime test for multiple versions #787
Add a runtime test for multiple versions #787
Conversation
the C# failure the following, looks like we might be missing the versioning info on the import.
|
This is waiting on release with bytecodealliance/wasmtime#7656 for rust tests. The c# should work after #791 |
Oh if you'd like it's ok to use a git dependency on |
sounds good, I will do that and drop the c# test until we get the other PR merged |
d7f9f21
to
3d42dba
Compare
@alexcrichton updated, I had to move a few dependencies, a couple type changes and regenerate the adapter module |
opened #802 to update the dependencies and will rebase on top of that |
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
3bac690
to
ec48cd9
Compare
ends up that wasmtime 0.16.0 didn't have the required commit. I saw the date of the release which was after my commit went in but I guess it was from a branch a little further back in time. wasmtime is only used as a dev dependency so I've moved it and made the required changes to the API. |
@alexcrichton up to you if you want to wait for a release for this or use the revision |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Mind dropping the rev
though in the dependency? I think the Cargo.lock
entry should suffice for that
Without the rev it will mean we will pull the tip of the main branch. I just tested it and this works but could cause issues down the line as the branch progresses? |
WIth a |
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
ec48cd9
to
8efead0
Compare
When working on #781 I noticed there wasn't a runtime test that had versions in the wit files. This adds test for a wit file that has multiple versions for rust and csharp.