-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c#: Encode version in namespace to support wit versions #781
Conversation
b5629d7
to
e224b1b
Compare
The refactor here exposed an issue with the way namespaces and files where generating: Prior to this change (on main) we were getting files like
Now we get
Which is actual what we really want. With #782 and a small tweak to the import Interop class this will pass |
|
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
e4c4f13
to
ab01fd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
Thanks! |
Prior to this change the multi-version wit was putting the functions from different versions into the same class which was causing the test to fail as there were multiple implementations of the same function:
Now the it generates a file for each version (if present) with the functions namespaced by version:
It also creates a file per version:
To note:
v
in front.