Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64: Add support for load+extends patterns #8774

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

afonso360
Copy link
Contributor

👋 Hey,

This PR adds support for merging a load with a {u,s}extend instruction. On AArch64 the load instructions already do this by default, so we can just emit the regular loads during the extend lowering and mark them as sunk.

CC: #6056

This commit adds support for merging a load with a `{u,s}extend` instruction. On AArch64 the load instructions already do this by default, so we can just emit the regular loads.

See also bytecodealliance#8765 that does a similar thing for RISC-V
@afonso360 afonso360 added the cranelift:area:aarch64 Issues related to AArch64 backend. label Jun 11, 2024
@afonso360 afonso360 requested a review from a team as a code owner June 11, 2024 17:49
@afonso360 afonso360 requested review from abrown and removed request for a team June 11, 2024 17:49
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cfallin cfallin enabled auto-merge June 11, 2024 17:51
@cfallin cfallin added this pull request to the merge queue Jun 11, 2024
Merged via the queue into bytecodealliance:main with commit 973bd49 Jun 11, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants