fix: full io virtualization #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the FS virtualization to instead be a comprehensive IO virtualization layer.
The reason for this is that as soon as streams and poll are virtualized, we need to virtualize all streams and polls since we cannot union with host streams and polls for passthrough unless we do indirect virtualization.
New stream and file descriptor types are introduced for host reference mappings, with the pass through interfaces updated.
This adds support for
stdioandexitsubsystems as well, assuming a reactor model so thatexitbecomes a panic. Stdio configuration is only ignore or allow currently, but we could support custom stream targets in future.This PR should resolve the bug in #6 (comment), and is a step towards full virtualization encapsulation as well.