Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to latest toolchain #6

Merged
merged 9 commits into from
Aug 9, 2023
Merged

deps: upgrade to latest toolchain #6

merged 9 commits into from
Aug 9, 2023

Conversation

guybedford
Copy link
Collaborator

This updates to the latest wasm-tools release, including the Wasmtime upgrade PR in bytecodealliance/wasmtime#6777.

Currently this fails when running cargo test on the fs test cases due to the panic at https://github.com/bytecodealliance/wasm-tools/blob/main/crates/wasm-compose/src/encoding.rs#L660.

@alexcrichton
Copy link
Member

I've opened bytecodealliance/wasm-tools#1147 to track the panic you're running into here which is from what we discussed on zulip

@guybedford
Copy link
Collaborator Author

guybedford commented Aug 1, 2023

I've updated this toolchain upgrade PR to the latest dependencies and rebased to main, but now am getting a new error in generating the WIT when running build-adapter.sh:

error: export parameter required for `wasi:poll/poll`
 --> virtual-adapter/src/lib.rs:6:1
  |
6 | / wit_bindgen::generate!({
7 | |     path: "../wit",
8 | |     world: "virtual-adapter"
9 | | });
  | |__^
  |
  = note: this error originates in the macro `wit_bindgen::generate` (in Nightly builds, run with -Z macro-backtrace for more info)

If I then edit the WIT file at wit/virt.wit to remove all the interface exports (but leave the imports), then it works.

Basically the failure seems to be for export wasi:poll/poll in the virtual-adapter world, where removing all of those fixes the issue.

@guybedford guybedford marked this pull request as ready for review August 1, 2023 18:37
@guybedford
Copy link
Collaborator Author

Ok, so this PR is now failing on the panic -

thread 'virt_test' panicked at 'failed to find alias of TypeId { index: 2, type_size: 1, unique_id: 2 }', /Users/gbedford/.cargo/git/checkouts/wasm-tools-30f99b8fb2d2db27/64fee0e/crates/wasm-compose/src/encoding.rs:660:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@guybedford
Copy link
Collaborator Author

Tests are finally all passing here. Will merge and release shortly.

@guybedford guybedford merged commit 6215e28 into main Aug 9, 2023
2 checks passed
@guybedford guybedford deleted the toolchain-upgrade branch August 9, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants