Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove use of nightly features in Cargo.toml #62

Merged
merged 2 commits into from
Jun 5, 2024
Merged

chore: remove use of nightly features in Cargo.toml #62

merged 2 commits into from
Jun 5, 2024

Commits on Jun 5, 2024

  1. chore: remove use of nightly features in Cargo.toml 

    The use of `profile-rustflags` is mainly to minimize the size of
virtual-adapter, but it's declared in the root Cargo.toml since it's
only allowed in the workspace root even though it's not used when
building wasi-virt crate.

The use of the nightly feature requires projects depending on wasi-virt
crate to also use nightly, which complicates the build process
(especially building native extensions of Ruby..)

This commit moves the `rustflags` setting from the Cargo.toml to the
RUSTFLAGS env var in build-adapter.sh.
    @kateinoigakukun
    kateinoigakukun committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    bf0fb09 View commit details
    Browse the repository at this point in the history

  2. doc: Remove note about nightly in README

    @kateinoigakukun
    kateinoigakukun committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    58351f1 View commit details
    Browse the repository at this point in the history