Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove use of nightly features in Cargo.toml #62

Conversation

kateinoigakukun
Copy link
Contributor

The use of profile-rustflags is mainly to minimize the size of virtual-adapter, but it's declared in the root Cargo.toml since it's only allowed in the workspace root even though it's not used when building wasi-virt crate.

The use of the nightly feature requires projects depending on wasi-virt crate to also use nightly, which complicates the build process (especially building native extensions of Ruby..)

This commit moves the rustflags setting from the Cargo.toml to the RUSTFLAGS env var in build-adapter.sh.

@guybedford
Copy link
Collaborator

Thank you! Can we also update the readme to remove the nightly mention then?

The use of `profile-rustflags` is mainly to minimize the size of
virtual-adapter, but it's declared in the root Cargo.toml since it's
only allowed in the workspace root even though it's not used when
building wasi-virt crate.

The use of the nightly feature requires projects depending on wasi-virt
crate to also use nightly, which complicates the build process
(especially building native extensions of Ruby..)

This commit moves the `rustflags` setting from the Cargo.toml to the
RUSTFLAGS env var in build-adapter.sh.
@guybedford guybedford merged commit b2581ff into bytecodealliance:main Jun 5, 2024
2 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/no-nightly-in-cargo-toml branch June 5, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants