Reorganize settings webui #20160
Merged
Reorganize settings webui #20160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave/brave-browser#32990 fix brave/brave-browser#32956 fix brave/brave-browser#32954 Moved social blocking menu as a shields' sub section. Moved new tab menu as a get started's sub section.
sangwoo108
approved these changes
Sep 14, 2023
| @@ -150,3 +123,32 @@ | |||
| </settings-subpage> | |||
| </template> | |||
| </settings-animated-pages> | |||
| <div hidden="[[isAdBlockRoute_]]"> | |||
There was a problem hiding this comment.
q. I'm curious why this was added. Was it removed accidentally?
There was a problem hiding this comment.
This page is used for two screen.
- brave://settings/shields
- brave://settings/shields/filters
Above second screen is shown when we click Content filtering option.
Then, isAdBlockRoute_ gives true and we need to hide all except filter subpage(adblck-subpage element).
| this.browserProxy_.setMetricsReportingEnabled(enabled); | ||
| } | ||
|
|
||
| setMetricsReportingPref_(metricsReporting: MetricsReporting) { |
There was a problem hiding this comment.
It looks like this was copied from the upstream code. It might be worth leaving comment about where it's from.
simonhong
force-pushed
the
settings_web_ui_restructuring
branch
from
4320adb
to
5d1e25c
Compare
github-actions
bot
added
the
CI/storybook-url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#32957
fix brave/brave-browser#32990
fix brave/brave-browser#32956
fix brave/brave-browser#32954
fix brave/brave-browser#32955
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: