Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Go Off-The-Record setting to below diagnostic reports #32955

Closed
rebron opened this issue Sep 13, 2023 · 2 comments · Fixed by brave/brave-core#20160
Closed

Move Go Off-The-Record setting to below diagnostic reports #32955

rebron opened this issue Sep 13, 2023 · 2 comments · Fixed by brave/brave-core#20160
Assignees
@simonhong
Labels
feature/settings OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.60.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 13, 2023

Description

In brave://settings/privacy Go Off-The-Record setting should go below the Automatically send diagnostic reports setting.

Expected result:

Screenshot 2023-09-12 at 8 18 59 PM

Current result:

1.58.x and 1.59.x
Screenshot 2023-09-12 at 8 22 18 PM

Brave version (brave://version info)

Target 1.60.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:
@rebron
Copy link
Collaborator Author

rebron commented Sep 13, 2023

cc: @ShivanKaul

@simonhong simonhong self-assigned this Sep 14, 2023
@simonhong simonhong mentioned this issue Sep 14, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 14, 2023
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Sep 28, 2023
Closed
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 6, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Oct 6, 2023 •
edited
Loading

Verified with

Brave | 1.60.81 Chromium: 118.0.5993.54 (Official Build) beta (x86_64)
-- | --
Revision | 1efb3f333eb41cc34af46ca31fb33c30e0afbfae
OS | macOS Version 13.6 (Build 22G120)

Confirmed setting placement was adjusted.

1.58.137 1.60.81
1 58 1 60

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/settings OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.60.x - Release
Development

Successfully merging a pull request may close this issue.

Reorganize settings webui brave/brave-core
4 participants
@rebron @simonhong @LaurenWags @brave-builds