Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 117 to Chromium 118 #32933

Closed
emerick opened this issue Sep 12, 2023 · 8 comments · Fixed by brave/brave-core#19765
Closed

Upgrade from Chromium 117 to Chromium 118 #32933

emerick opened this issue Sep 12, 2023 · 8 comments · Fixed by brave/brave-core#19765
Assignees
@emerick @samartnik @cdesouza-chromium
Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified release-notes/exclude
Milestone
1.59.x - Release

Comments

@emerick
Copy link
Contributor

emerick commented Sep 12, 2023 •
edited by samartnik
Loading

Upgrade from Chromium 117 to Chromium 118

https://chromium.googlesource.com/chromium/src/+log/117.0.5938.48..118.0.5993.3/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • Verify side panel functionality
  • Verify brave://settings functionality
  • Verify autofill works as expected
  • Verify that site page info button looks/behaves as expected
  • Verify that tab shapes/spacing/etc. look correct
  • Verify cookie-related functionality
  • Verify permissions-related functionality

iOS Affected areas:

  • No specific changes

Android Affected areas:

  • Top toolbar (check that there is no excessive items in phones and tablets)
  • Sync (double check it generally works)
  • Make sure url is not removed on url bar focus [Android] Do not clear url bar text on focus #10524
  • NTP layout (check that there is no regression in look)
  • Brave search promo (double check there is no regression in showing it)
  • Safe Browsing (double check there is no regression)
@emerick emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop labels Sep 12, 2023
@emerick emerick mentioned this issue Sep 12, 2023
Merged
25 tasks
@emerick emerick added this to the 1.60.x - Nightly milestone Sep 27, 2023
@brave-builds brave-builds added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels Sep 27, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 28, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.60.63 Chromium: 118.0.5993.21 (Official Build) nightly (64-bit)
-- | --
Revision | 3c2401f1c61504c037363a33b8f4f1fc7423a95f
OS | Windows 10 Version 22H2 (Build 19045.3448)
Verify side panel functionality_PASSED
  • Confirmed that sidebar is shown by default in the nightly channel
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown in the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
  • Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list
  • Confirmed that tooltip is shown correctly for each menu item in sidebar
  • Confirmed that click on each sidepanel button Brave Talk, wallet, Bookmarks and REading list works as expected
Verify brave://settings functionality_PASSED
  1. No new settings are added as part of CR118
  2. Settings webui is reorganized as a part of Reorganize settings webui  brave-core#20160
  3. Order of left navigation settings is updated as part of Update left navigation order in brave://settings #32990
  4. New tab Page settings are added under the Getstarted settings as part of Reorganize settings webui  brave-core#20160
  5. Social media settings are moved to shield settings as part of Move brave://settings/socialBlocking to brave://settings/shields #32956
  6. In Shields, toggle settings are moved below the Shields settings as part of In Shields, move toggle settings below the Shields settings #32957
  7. Moved Go Off-The-Record setting to below diagnostic reports as part of Move Go Off-The-Record setting to below diagnostic reports #32955
step 3 step 4 step 5 step 6 step 7
image image image image image
Verify autofill works as expected_PASSED

Note: Create a junk autofill data via brave://settings/autofill and then visit the form https://srirambv.github.io/formfiller.html to check the autofill data

  • Confirmed autofill works as expected in a Regular window
  • Confirmed autofil works as expected in a Private window
  • Confirmed autofil works as expected in a Private TOR window
Regular window Private window TOR window
image image image
image image image
Verify that site page info button looks/behaves as expected_PASSED

Default info

  • Conformed that click on lock icon shows the info dialog which has site name, connection is secure , cookies and site data and Site settings as expected
  • Confirmed that click on Connection is secure shows the info dialog as expected also click on Certificate valid shows the info as expected
  • Confirmed that click on Cookies displays the cookies info
  • Confirmed that click on the Site settings opens up the content settings for a site as expected
Example Example Example Example
image image image image

Update the cookies setting

  1. Open a site A and and tap on the lock icon and ensured that the cross-site cookies are blocked on the site A
  2. Go to global shield settings and change the cookies setting to "Block all"
  3. Reload the site A and click on the lock icon and ensure that the cookies blocked and cookies allowed count is zero '0`
  4. Open brave://settings/cookies and ensure that the Block cookies settings is enabled due to step 2
  5. Go to brave://settings/cookies and select "Allow all cookies"
  6. Reload the site A and click on the lock icon and ensured that the cookies are allowed and count value is "some value"
  7. Go to global shield settings and ensure that the cookies setting is set to "Disabled" due to step 5
step 1 step 2 step 3 step 4 step 5 step 6 step 7
image image image image image image image

Update site settings via lock icon

  1. Open youtube.com and open any video and click on the lock icon and navigate to site settings
  2. Set "Autoplay" settings to "Block"
  3. Reload the video
  4. Confirm that autoplay was blocked on this page icon is shown on the URL bar (icon is not shown hence logged Autoplay was blocked on this site icon is NOT shown on the URL bar when autoplay is blocked on a video #33309)
  5. Tap on the icon and allow the autoplay (I have enabled autoplay manually via content settings)
  6. Tap on the lock icon and ensure that "Sound" setting is enabled
  7. Disable the "Sound" settings via lock icon
  8. Confirm that video is playing without audio
  9. Go to site setting and change the setting from "Mute" to "Allow"
  10. Reload the video and ensure that the audio is autoplayed
Example Example Example Example Example
image image image image image
Verify that tab shapes/spacing/etc. look correct_PASSED
Horizontal Tab orientation_PASSED
  • Confirmed tab shapes/spacing works as expected
  • Confirmed that Tab hover modes works as expected
Card Card with Preview Tooltip
image image image
Vertical Tab orientation_PASSED
  • Confirmed tab shapes/spacing works as expected
  • Confirmed that Tab hover modes works as expected
Card Card with Preview Tooltip
image image image
Verify cookie-related functionality_PASSED

Verified the update cookies settings via Verify that site page info button looks/behaves as expected case above

Verify local shield cookies settings works as expected_PASSED
  1. Clean profile 1.60.64
  2. Open a site A
  3. Open shield settings
  4. Change the default cookies shield settings to "allow all cookies"
  5. Restart the browser
  6. Confirmed that the selected cookies settings is reatined on the shield
  7. Click on the lock icon and open cookies and site data and ensured that all cookies are allowed on the Site A
  8. Open shield settings for site A, change the cookies shield settings to "block all cookies"
  9. Restart the browser
  10. Confirmed that the selected cookies settings is reatined on the shield
  11. Click on the lock icon and open cookies and site data and ensured that all cookies are blocked on the Site A
Verify global shield cookies settings works as expected_PASSED
  1. Clean profile 1.60.64
  2. Open bunch of sites
  3. Open global shield settings
  4. Change the default cookies shield settings to "allow all cookies"
  5. Open the shield settings for all the sites and ensured "allow all cookies" settings is selected
  6. Click on the lock icon on each site and open cookies and site data and ensured that all cookies are allowed on all the sites
  7. Restart the browser
  8. Confirmed that the selected cookies settings is reatined on the shield
  9. Change the default cookies shield settings to "block all cookies" via global shield settings
  10. Open the shield settings for all the sites and ensured "block all cookies" settings is selected
  11. Click on the lock icon on each site and open cookies and site data and ensured that all cookies are blocked on all the sites
  12. Restart the browser
  13. Confirmed that the selected cookies settings is reatined on the shield

@emerick emerick mentioned this issue Sep 28, 2023
Merged
25 tasks
@LaurenWags
Copy link
Member

LaurenWags commented Sep 29, 2023 •
edited
Loading

Verified with

Brave	1.60.66 Chromium: 118.0.5993.21 (Official Build) nightly (64-bit) 
Revision	a3848348ec9895278df0afe28d1ad123335f18c2
OS	Windows 10 Version 22H2 (Build 19045.3086)
Verify permissions-related functionality - PASSED

Generally:

  • spot checked a couple permission types
  • spot checked allow/block
  • spot checked several permission lifetime values
  • spot checked permission being correctly reflected on tune icon and under the appropriate section of brave://settings/content
  • used site where permission is requested on site open and a site where permission is requested upon user action take on site
1. Location - PASSED
  • Visited browserleaks.com/geo
  • Confirmed location permission prompt displayed as expected
  • Kept default selection of "Until I close this site" and selected "Block"
  • Confirmed permission shows as denied via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/location
Example Example Example
1 2 3
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/location
  • Confirmed site was no longer listed
  • Reopened site
  • Confirmed re-prompted for permission
Example Example
4 5
  • Changed permission lifetime value to "1 week" and selected "Allow"
  • Confirmed permission shows as allowed via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/location
Example Example Example
6 7 8
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/location
  • Confirmed site was still listed as "allowed"
  • Reopened site
  • Confirmed not prompted for permission
  • Closed site, closed browser
  • Advanced computer clock a few days (~3)
  • Reopened browser
  • Confirmed site was still listed as "allowed" on brave://settings/content/location
  • Visited site and confirmed not prompted for permission
  • Closed site, closed browser
Example Example Example
9 10 11
  • Advanced computer clock (~8 days from the day the permission was set)
  • Reopened browser
  • Visited brave://settings/content/location
  • Confirmed site was no longer listed on this page
  • Visited site and confirmed prompted for permission
Example Example Example
12 13 14
2. Notifications - PASSED
  • Visited permission.site, selected "Notifications" button
  • Confirmed notification permission prompt displayed as expected
  • Kept default selection of "Until I close this site" and selected "Allow"
  • Confirmed permission shows as allowed via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/notifications
Example Example Example
1 2 3
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/notifications
  • Confirmed site was no longer listed
  • Reopened site, selected "Notifications" button
  • Confirmed re-prompted for permission
Example Example
4 5
  • Changed permission lifetime value to "24 hours" and selected "Block"
  • Confirmed permission shows as denied via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/notifications
Example Example Example
6 7 8
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/notifications
  • Confirmed site was still listed as "not allowed"
  • Reopened site, clicked on "Notifications" button
  • Confirmed not prompted for permission
  • Closed site, closed browser
  • Advanced computer clock 23 hrs
  • Reopened browser
  • Confirmed site was still listed as "denied" on brave://settings/content/notifications
  • Visited site, clicked "Notifications" button and confirmed not prompted for permission
  • Closed site, closed browser
Example Example Example
9 10 11
  • Advanced computer clock (25 hours from the time when the permission was set)
  • Reopened browser
  • Visited brave://settings/content/notifications
  • Confirmed site was no longer listed on this page
  • Visited site, clicked "Notifications" button and confirmed prompted for permission
Example Example Example
12 13 14

@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 29, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.60.64 Chromium: 118.0.5993.21 (Official Build) nightly (64-bit)
-- | --
Revision | f05e9ca819b9af4850b13764e15631322922d47c
OS | Windows 11 Version 22H2 (Build 22621.2283)
Verify permissions-related functionality - PASSED

Generally:

  • spot checked a couple permission types
  • spot checked allow/block
  • spot checked several permission lifetime values
  • spot checked permission being correctly reflected on tune icon and under the appropriate section of brave://settings/content
  • used site where permission is requested on site open and a site where permission is requested upon user action take on site
1. Location - PASSED

**Allow**

  1. visited browserleaks.com/geo
  2. confirmed location permission prompt displayed as expected
  3. kept default selection of "Until I close this site" and selected "Allow"
  4. confirmed permission shows as Allowed via tune icon in URL bar
  5. confirmed permission bubble has closed
  6. clicked tune icon and confirmed Location toggle is enabled
  7. clicked Site settings via tune icon
  8. confirmed Location permissions shown Allow
  9. confirmed expected behavior on brave://settings/content/location
step 2 step 4-6 step 8 step 9
image image image image
  1. Closed the site
  2. Waited at least 30s and looked at brave://settings/content/location
  3. Confirmed site was no longer listed
  4. Reopened site
  5. Confirmed re-prompted for permission
  6. Confirmed Location permissions shown Ask
step 3 step 5 step 6
image image image

**Block**

  1. Continue from Above
  2. Changed permission lifetime value to "for 24 hours" and selected "Block"
  3. Confirmed permission shows as Not allowed via tune icon in URL bar
  4. confirmed permission bubble has closed
  5. clicked tune icon and confirmed Location toggle is disabled
  6. clicked Site settings via tune icon
  7. confirmed Location permissionsshownBlock`
  8. confirmed expected behavior on brave://settings/content/location
Example Example Example
image image image
  1. Closed the site
  2. Waited at least 30s and looked at brave://settings/content/location
  3. Confirmed site was still listed as "not allowed"
  4. Reopened site and confirmed not prompted for permission
  5. Closed site, closed browser
  6. Advanced computer clock 23 hrs
  7. Reopened browser
  8. Confirmed site was still listed as Block on brave://settings/content/siteDetails?site=https%3A%2F%2Fbrowserleaks.com
  9. Confirmed site was still listed as "denied" on brave://settings/content/location
  10. Visited site and confirmed not prompted for permission
  11. Closed site, closed browser
step 3 step 4 step 6 step 8 step 9 step 10
image image image image image image
  1. Advanced computer clock (25 hours from the time when the permission was set)
  2. Reopened browser
  3. Visited brave://settings/content/notifications
  4. Confirmed site was no longer listed on this page
  5. Visited site and confirmed prompted for permission
  6. Confirmed Location show Ask in brave://settings/content/siteDetails?site=https%3A%2F%2Fbrowserleaks.com `
step 1 step 3 step 5 step 6
image image image image
2. Notifications - PASSED

Block

  1. Visited permission.site, selected "Notifications" button
  2. Confirmed notification permission prompt displayed as expected
  3. Kept default selection of "Until I close this site" and selected "Block"
  4. Confirmed permission shows as Not allowed via tune icon in URL bar
  5. Confirmed expected behavior on brave://settings/content/notifications
step 3 step 4 step 6
image image image
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/notifications
  • Confirmed site was no longer listed
  • Reopened site, selected "Notifications" button
  • Confirmed re-prompted for permission
Example Example
image image

Allow

  • Changed permission lifetime value to "for 1 week" and selected "Allow"
  • Confirmed permission shows as Allowed via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/notifications
Example Example Example
image image image
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/notifications
  • Confirmed site was still listed as "Allowed"
  • Reopened site, clicked on "Notifications" button
  • Confirmed not prompted for permission
  • Closed site, closed browser
  • Advanced computer clock a few days (~3)
  • Reopened browser
  • Confirmed site was still listed as "Allowed" on brave://settings/content/notifications
  • Visited site and confirmed not prompted for permission
  • Closed site, closed browser
Example Example Example Example Example
image image image image image
  • Advanced computer clock (~8 days from the day the permission was set)-
  • Reopened browser
  • Visited brave://settings/content/location
  • Confirmed site was no longer listed on this page
  • Visited site, clicked Notification and confirmed prompted for permission
Example Example Example
image image image

@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 29, 2023 •
edited
Loading

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.60.64 Chromium: 118.0.5993.21 (Official Build) canary (64-bit) 
Revision	f05e9ca819b9af4850b13764e15631322922d47c
OS	Android 13; Build/TP1A.220624.014; 33; REL
Top toolbar
  • Ensured no extra items are present in top toolbar
  • Ensured all icons are functional
Example Example
Screenshot 2023-09-29 at 1 25 20 PM Screenshot 2023-09-29 at 1 25 46 PM
Sync
  • Ensured sync chain is working and sync data is shown on device.
Example Example Example Example Example Example
Screenshot 2023-09-29 at 1 42 51 PM Screenshot 2023-09-29 at 1 42 56 PM Screenshot 2023-09-29 at 1 43 05 PM Screenshot 2023-09-29 at 1 43 13 PM Screenshot 2023-09-29 at 1 43 20 PM Screenshot 2023-09-29 at 1 43 57 PM
URL bar

encountered: #33333

  • Ensured URL text is not removed upon URL bar focus

Screenshot 2023-09-29 at 12 00 24 PM

NTP layout
  • Ensured disabling the different elements in New Tab Page settings is reflected on NTP.
  • Ensured restart prompt is shown when toggling on the settings for NTP.
  • Ensured SI are shown on NTP and can be disabled.
  • Ensured Brave News onboarding card is shown.
  • Ensured news feed is displayed when opting into news.
Example Example Example Example Example
Screenshot 2023-09-29 at 1 25 46 PM Screenshot 2023-09-29 at 1 26 04 PM Screenshot 2023-09-29 at 1 34 28 PM Screenshot 2023-09-29 at 1 41 41 PM Screenshot 2023-09-29 at 1 42 30 PM
Search Promo
Safe Browsing
  • Ensured Safe Browsing protection is on by default
  • Ensured warning interstitial is displayed when tapping on malicious links.
Example Example Example Example Example
Screenshot 2023-09-29 at 2 16 07 PM Screenshot 2023-09-29 at 2 16 12 PM Screenshot 2023-09-29 at 2 11 13 PM Screenshot 2023-09-29 at 2 11 20 PM Screenshot 2023-09-29 at 2 11 30 PM

@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 2, 2023 •
edited
Loading

Verified on Samsung Galaxy S21 using version:

Brave	1.60.67 Chromium: 118.0.5993.21 (Official Build) canary (64-bit) 
Revision	c5f60a0c302159013a1ac92620f35f570c8f5531
OS	Android 13; Build/TP1A.220624.014; 33; REL
Top toolbar
  • Ensured no extra items are present in top toolbar
  • Ensured all icons are functional
Example Example
Screenshot 2023-10-02 at 11 52 24 AM Screenshot 2023-10-02 at 11 52 32 AM
Sync
  • Ensured sync chain is working and sync data is shown on device.
Example Example Example Example
Screenshot 2023-10-02 at 11 01 42 AM Screenshot 2023-10-02 at 11 01 46 AM Screenshot 2023-10-02 at 11 01 49 AM Screenshot 2023-10-02 at 11 55 53 AM
URL bar

encountered: #33333

  • Ensured URL text is not removed upon URL bar focus
NTP layout
  • Ensured disabling the different elements in New Tab Page settings is reflected on NTP.
  • Ensured restart prompt is shown when toggling on the settings for NTP.
  • Ensured SI are shown on NTP and can be disabled.
  • Ensured Brave News onboarding card is shown.
  • Ensured news feed is displayed when opting into news.
Example Example Example Example Example
Screenshot 2023-10-02 at 10 25 04 AM Screenshot 2023-10-02 at 10 28 13 AM Screenshot 2023-10-02 at 10 28 28 AM Screenshot 2023-10-02 at 10 34 31 AM Screenshot 2023-10-02 at 10 35 43 AM
Search Promo
Safe Browsing
  • Ensured Safe Browsing protection is on by default
  • Ensured warning interstitial is displayed when tapping on malicious links.
Example Example Example Example
Screenshot 2023-10-02 at 11 37 42 AM Screenshot 2023-10-02 at 11 37 46 AM Screenshot 2023-10-02 at 11 38 03 AM Screenshot 2023-10-02 at 11 38 26 AM

@kjozwiak
Copy link
Member

kjozwiak commented Oct 2, 2023

The above requires 1.59.108 or higher for 1.59.x verification 👍

@srirambv srirambv removed feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels Oct 3, 2023
@LaurenWags LaurenWags added QA Pass-Win64 QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 3, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Oct 3, 2023 •
edited
Loading

Verified with

Brave | 1.59.109 Chromium: 118.0.5993.21 (Official Build) beta (x86_64)
-- | --
Revision | aacb6a6f8bd916bd49f064b2137b007fa6c47b51
OS | macOS Version 13.6 (Build 22G120)
Verify side panel functionality - PASSED
  • Confirmed that sidebar is shown by default in the beta channel
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown next to the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown next to the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
  • Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list
  • Confirmed that tooltip is shown correctly for each menu item in sidebar
  • Confirmed that click on each side panel button Brave Talk, Wallet, Bookmarks and Reading list works as expected
Verify brave://settings functionality - PASSED
Verify autofill works as expected - PASSED

Note: Create a junk autofill data via brave://settings/autofill and then visit the form https://srirambv.github.io/formfiller.html to check the autofill data

  • Confirmed autofill works as expected in a Regular window
  • Confirmed autofil works as expected in a Private window
  • Confirmed autofil works as expected in a Private TOR window
Regular window Private window TOR window
1 2 3
Verify that site page info button looks/behaves as expected - PASSED

Default info

  • Confirmed that click on the tune icon shows the info dialog which has site name, connection is secure , cookies and site data and Site settings as expected
  • Confirmed that click on Connection is secure shows the info dialog as expected also click on Certificate valid shows the info as expected
  • Confirmed that click on Cookies displays the cookies info
  • Confirmed that click on the Site settings opens up the content settings for a site as expected
Example Example Example Example
1 2 3 4

Update the cookies setting

  1. Open a site A and and tap on the lock icon and ensured that the cross-site cookies are blocked on the site A
  2. Go to global shield settings and change the cookies setting to "Block all"
  3. Reload the site A and click on the lock icon and ensure that the cookies blocked and cookies allowed count is zero '0`
  4. Open brave://settings/cookies and ensure that the Block cookies settings is enabled due to step 2
  5. Go to brave://settings/cookies and select "Allow all cookies"
  6. Reload the site A and click on the lock icon and ensured that the cookies are allowed and count value is "some value"
  7. Go to global shield settings and ensure that the cookies setting is set to "Disabled" due to step 5
step 1 step 2 step 3 step 4 step 5 step 6 step 7
1 2 3 4 5 6 7

Update site settings via lock icon

  1. Open youtube.com and open any video and click on the lock icon and navigate to site settings
  2. Set "Autoplay" settings to "Block"
  3. Reload the video
  4. Confirm that autoplay was blocked on this page icon is shown on the URL bar (icon is not shown hence logged Autoplay was blocked on this site icon is NOT shown on the URL bar when autoplay is blocked on a video #33309)
  5. Tap on the icon and allow the autoplay (I have enabled autoplay manually via content settings)
  6. Tap on the lock icon and ensure that "Sound" setting is enabled
  7. Disable the "Sound" settings via lock icon
  8. Confirm that video is playing without audio
  9. Go to site setting and change the setting from "Mute" to "Allow"
  10. Reload the video and ensure that the audio is autoplayed
Example Example Example Example Example Example
1 2 3 4 5 6
Verify that tab shapes/spacing/etc. look correct - PASSED
Horizontal Tab orientation - PASSED
  • Confirmed tab shapes/spacing works as expected
  • Confirmed that Tab hover modes works as expected
Card Card with Preview Tooltip
1 2 3
Vertical Tab orientation - PASSED
  • Confirmed tab shapes/spacing works as expected
  • Confirmed that Tab hover modes works as expected
Card Card with Preview Tooltip
1 2 3
Verify cookie-related functionality - PASSED

Verified the update cookies settings via Verify that site page info button looks/behaves as expected case above

Verify local shield cookies settings works as expected - PASSED
  1. Clean profile 1.59.x
  2. Open a site A
  3. Open shield settings
  4. Change the default cookies shield settings to "allow all cookies"
  5. Restart the browser
  6. Confirmed that the selected cookies settings is retained on the shield
  7. Click on the lock icon and open cookies and site data and ensured that all cookies are allowed on the Site A
  8. Open shield settings for site A, change the cookies shield settings to "block all cookies"
  9. Restart the browser
  10. Confirmed that the selected cookies settings is retained on the shield
  11. Click on the lock icon and open cookies and site data and ensured that all cookies are blocked on the Site A
Verify global shield cookies settings works as expected - PASSED
  1. Clean profile 1.59.x
  2. Open bunch of sites
  3. Open global shield settings
  4. Change the default cookies shield settings to "Disabled" (this will "Allow all cookies")
  5. Open the shield settings for all the sites and ensured "allow all cookies" settings is selected
  6. Click on the lock icon on each site and open cookies and site data and ensured that all cookies are allowed on all the sites (refresh each site first)
  7. Restart the browser
  8. Confirmed that the selected cookies settings is retained on the shield
  9. Open global shield settings.
  10. Change the default cookies shield settings to "All" (this will "block all cookies")
  11. Open the shield settings for all the sites and ensured "block all cookies" settings is selected
  12. Click on the lock icon on each site and open cookies and site data and ensured that all cookies are blocked on all the sites (refresh each site first)
  13. Restart the browser
  14. Confirmed that the selected cookies settings is retained on the shield
Verify permissions-related functionality - PASSED

Generally:

  • spot checked a couple permission types
  • spot checked allow/block
  • spot checked several permission lifetime values
  • spot checked permission being correctly reflected on tune icon and under the appropriate section of brave://settings/content
  • used site where permission is requested on site open and a site where permission is requested upon user action take on site
1. Location - PASSED
  • Visited browserleaks.com/geo
  • Confirmed location permission prompt displayed as expected
  • Kept default selection of "Until I close this site" and selected "Block"
  • Confirmed permission shows as denied via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/location
Example Example Example
1 2 3
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/location
  • Confirmed site was no longer listed
  • Reopened site
  • Confirmed re-prompted for permission
Example Example
4 5
  • Changed permission lifetime value to "1 week" and selected "Allow"
  • Confirmed permission shows as allowed via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/location
Example Example Example
6 7 8
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/location
  • Confirmed site was still listed as "allowed"
  • Reopened site
  • Confirmed not prompted for permission
  • Closed site, closed browser
  • Advanced computer clock a few days (~3)
  • Reopened browser
  • Confirmed site was still listed as "allowed" on brave://settings/content/location
  • Visited site and confirmed not prompted for permission
  • Closed site, closed browser
Example Example Example
9 10 11
  • Advanced computer clock (~8 days from the day the permission was set)
  • Reopened browser
  • Visited brave://settings/content/location
  • Confirmed site was no longer listed on this page
  • Visited site and confirmed prompted for permission
Example Example Example
12 13 14
2. Notifications - PASSED
  • Visited permission.site, selected "Notifications" button
  • Confirmed notification permission prompt displayed as expected
  • Kept default selection of "Until I close this site" and selected "Allow"
  • Confirmed permission shows as allowed via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/notifications
Example Example Example
1 2 3
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/notifications
  • Confirmed site was no longer listed
  • Reopened site, selected "Notifications" button
  • Confirmed re-prompted for permission
Example Example
4 5
  • Changed permission lifetime value to "24 hours" and selected "Block"
  • Confirmed permission shows as denied via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/notifications
Example Example Example
6 7 8
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/notifications
  • Confirmed site was still listed as "not allowed"
  • Reopened site, clicked on "Notifications" button
  • Confirmed not prompted for permission
  • Closed site, closed browser
  • Advanced computer clock 23 hrs
  • Reopened browser
  • Confirmed site was still listed as "denied" on brave://settings/content/notifications
  • Visited site, clicked "Notifications" button and confirmed not prompted for permission
  • Closed site, closed browser
Example Example Example
9 10 11
  • Advanced computer clock (25 hours from the time when the permission was set)
  • Reopened browser
  • Visited brave://settings/content/notifications
  • Confirmed site was no longer listed on this page
  • Visited site, clicked "Notifications" button and confirmed prompted for permission
Example Example Example
12 13 14

@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 3, 2023 •
edited
Loading

Verification PASSED using

Brave	1.59.109 Chromium: 118.0.5993.21 (Official Build) beta (64-bit) 
Revision	aacb6a6f8bd916bd49f064b2137b007fa6c47b51
OS	Linux
Verify side panel functionality - PASSED
  • Confirmed that sidebar is shown by default in the beta channel
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown next to the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown next to the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
  • Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list
  • Confirmed that tooltip is shown correctly for each menu item in sidebar
  • Confirmed that click on each side panel button Brave Talk, Wallet, Bookmarks and Reading list works as expected
Verify brave://settings functionality - PASSED
1.58.122 1.59.109
image !image
  • brave://settings/system - Always keep these sites active entry has additional sub text in 1.59.109 - Leaving the text as is
1.58.122 1.59.109
image image
Verify autofill works as expected - PASSED ***Note: Create a junk autofill data via brave://settings/autofill and then visit the form https://srirambv.github.io/formfiller.html to check the autofill data
  • Confirmed autofill works as expected in a Regular window
  • Confirmed autofil works as expected in a Private window
  • Confirmed autofil works as expected in a Private TOR window
Regular window Private window Tor window
image image image
Verify that site page info button looks/behaves as expected - PASSED

Default info

  • Confirmed that click on the tune icon shows the info dialog which has site name, connection is secure , cookies and site data and Site settings as expected
  • Confirmed that click on Connection is secure shows the info dialog as expected also click on Certificate valid shows the info as expected
  • Confirmed that click on Cookies displays the cookies info
  • Confirmed that click on the Site settings opens up the content settings for a site as expected
Example Example Example Example
image image image image

Update the cookies setting

  1. Open a site A and and tap on the lock icon and ensured that the cross-site cookies are blocked on the site A
  2. Go to global shield settings and change the cookies setting to "Block all"
  3. Reload the site A and click on the lock icon and ensure that the cookies blocked and cookies allowed count is zero '0`
  4. Open brave://settings/cookies and ensure that the Block cookies settings is enabled due to step 2
  5. Go to brave://settings/cookies and select "Allow all cookies"
  6. Reload the site A and click on the lock icon and ensured that the cookies are allowed and count value is "some value"
  7. Go to global shield settings and ensure that the cookies setting is set to "Disabled" due to step 5
step 1 step 2 step 3 step 4 step 5 step 6 step 7
image image image image image image image

Update site settings via lock icon

  1. Open youtube.com and open any video and click on the lock icon and navigate to site settings
  2. Set "Autoplay" settings to "Block"
  3. Reload the video
  4. Confirm that autoplay was blocked on this page icon is shown on the URL bar (icon is not shown hence logged Autoplay was blocked on this site icon is NOT shown on the URL bar when autoplay is blocked on a video #33309)
  5. Tap on the icon and allow the autoplay (I have enabled autoplay manually via content settings)
  6. Tap on the lock icon and ensure that "Sound" setting is enabled
  7. Disable the "Sound" settings via lock icon
  8. Confirm that video is playing without audio
  9. Go to site setting and change the setting from "Mute" to "Allow"
  10. Reload the video and ensure that the audio is autoplayed
Example Example Example Example Example Example Example
image image image image image image image
Verify that tab shapes/spacing/etc. look correct - PASSED
Horizontal Tab orientation - PASSED
  • Confirmed tab shapes/spacing works as expected
  • Confirmed that Tab hover modes works as expected
Card Card with Preview Tooltip
image image image
Vertical Tab orientation - PASSED
  • Confirmed tab shapes/spacing works as expected
  • Confirmed that Tab hover modes works as expected
Card Card with Preview Tooltip
image image image
Verify cookie-related functionality - PASSED

Verified the update cookies settings via Verify that site page info button looks/behaves as expected case above

Verify local shield cookies settings works as expected - PASSED
  1. Clean profile 1.59.x
  2. Open a site A
  3. Open shield settings
  4. Change the default cookies shield settings to "allow all cookies"
  5. Restart the browser
  6. Confirmed that the selected cookies settings is retained on the shield
  7. Click on the lock icon and open cookies and site data and ensured that all cookies are allowed on the Site A
  8. Open shield settings for site A, change the cookies shield settings to "block all cookies"
  9. Restart the browser
  10. Confirmed that the selected cookies settings is retained on the shield
  11. Click on the lock icon and open cookies and site data and ensured that all cookies are blocked on the Site A
Verify global shield cookies settings works as expected - PASSED
  1. Clean profile 1.59.x
  2. Open bunch of sites
  3. Open global shield settings
  4. Change the default cookies shield settings to "Disabled" (this will "Allow all cookies")
  5. Open the shield settings for all the sites and ensured "allow all cookies" settings is selected
  6. Click on the lock icon on each site and open cookies and site data and ensured that all cookies are allowed on all the sites (refresh each site first)
  7. Restart the browser
  8. Confirmed that the selected cookies settings is retained on the shield
  9. Open global shield settings.
  10. Change the default cookies shield settings to "All" (this will "block all cookies")
  11. Open the shield settings for all the sites and ensured "block all cookies" settings is selected
  12. Click on the lock icon on each site and open cookies and site data and ensured that all cookies are blocked on all the sites (refresh each site first)
  13. Restart the browser
  14. Confirmed that the selected cookies settings is retained on the shield
Verify permissions-related functionality - PASSED

Generally:

  • spot checked a couple permission types
  • spot checked allow/block
  • spot checked several permission lifetime values
  • spot checked permission being correctly reflected on tune icon and under the appropriate section of brave://settings/content
  • used site where permission is requested on site open and a site where permission is requested upon user action take on site
1. Location - PASSED

**Allow**

  1. visited browserleaks.com/geo
  2. confirmed location permission prompt displayed as expected
  3. kept default selection of "Until I close this site" and selected "Allow"
  4. confirmed permission shows as Allowed via tune icon in URL bar
  5. confirmed permission bubble has closed
  6. clicked tune icon and confirmed Location toggle is enabled
  7. clicked Site settings via tune icon
  8. confirmed Location permissions shown Allow
  9. confirmed expected behavior on brave://settings/content/location
step 2 step 4-5 step 6 step 8 step 9
image image image image image
  1. Closed the site
  2. Waited at least 30s and looked at brave://settings/content/location
  3. Confirmed site was no longer listed
  4. Reopened site
  5. Confirmed re-prompted for permission
  6. Confirmed Location permissions shown Ask
step 3 step 5 step 6
image image image

**Block**

  1. Continue from Above
  2. Changed permission lifetime value to "for 24 hours" and selected "Block"
  3. Confirmed permission shows as Not allowed via tune icon in URL bar
  4. confirmed permission bubble has closed
  5. clicked tune icon and confirmed Location toggle is disabled
  6. clicked Site settings via tune icon
  7. confirmed Location permissionsshownBlock`
  8. confirmed expected behavior on brave://settings/content/location
step 2 step 3 step 5 step 7 step 8
image image image image image
  1. Closed the site
  2. Waited at least 30s and looked at brave://settings/content/location
  3. Confirmed site was still listed as "not allowed"
  4. Reopened site and confirmed not prompted for permission
  5. Closed site, closed browser
  6. Advanced computer clock 23 hrs
  7. Reopened browser
  8. Confirmed site was still listed as Block on brave://settings/content/siteDetails?site=https%3A%2F%2Fbrowserleaks.com
  9. Confirmed site was still listed as "denied" on brave://settings/content/location
  10. Visited site and confirmed not prompted for permission
  11. Closed site, closed browser
step 3 step 4 step 6 step 8 step 9 step 10
image image image image image image
  1. Advanced computer clock (25 hours from the time when the permission was set)
  2. Reopened browser
  3. Visited brave://settings/content/notifications
  4. Confirmed site was no longer listed on this page
  5. Visited site and confirmed prompted for permission
  6. Confirmed Location show Ask in brave://settings/content/siteDetails?site=https%3A%2F%2Fbrowserleaks.com `
step 1 step 3 step 5 step 6
image image image image
2. Notifications - PASSED

Block

  1. Visited permission.site, selected "Notifications" button
  2. Confirmed notification permission prompt displayed as expected
  3. Kept default selection of "Until I close this site" and selected "Block"
  4. Confirmed permission shows as Not allowed via tune icon in URL bar
  5. Clicked tune icon and confirmed Location toggle is disabled
  6. Confirmed expected behavior on brave://settings/content/notifications
step 2 step 4 step 5 step 6
image image image image
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/notifications
  • Confirmed site was no longer listed
  • Reopened site, selected "Notifications" button
  • Confirmed re-prompted for permission
Example Example
image image

Allow

  • Changed permission lifetime value to "for 1 week" and selected "Allow"
  • Confirmed permission shows as Allowed via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/notifications
Example Example Example Example
image image image image
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/notifications
  • Confirmed site was still listed as "Allowed"
  • Reopened site, clicked on "Notifications" button
  • Confirmed not prompted for permission
  • Closed site, closed browser
  • Advanced computer clock a few days (~3)
  • Reopened browser
  • Confirmed site was still listed as "Allowed" on brave://settings/content/notifications
  • Visited site and confirmed not prompted for permission
  • Closed site, closed browser
Example Example Example Example Example
image image image image image
  • Advanced computer clock (~8 days from the day the permission was set)-
  • Reopened browser
  • Visited brave://settings/content/location
  • Confirmed site was no longer listed on this page
  • Visited site, clicked Notification and confirmed prompted for permission
Example Example Example
image image image

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 4, 2023
@kjozwiak kjozwiak mentioned this issue Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@samartnik samartnik

@cdesouza-chromium cdesouza-chromium

Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 117 to Chromium 118 brave/brave-core
10 participants
@kjozwiak @emerick @srirambv @Uni-verse @LaurenWags @samartnik @cdesouza-chromium @GeetaSarvadnya @brave-builds @MadhaviSeelam