Update SDK to 0.12.0 #1014
Merged
Update SDK to 0.12.0 #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustc's `lto` flag is incompatible with the new `embed-bitcode=no`. The release notes for Rust 1.45 recommend controlling LTO with Cargo profiles, and one way to do that is setting `CARGO_PROFILE_<name>_LTO` in the environment.
bcressey
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
n/a
Description of changes:
Move to SDK v0.12.0 (bottlerocket-os/bottlerocket-sdk#30). Two changes on the Bottlerocket side:
embed-bitcodeflag conflicts with-C lto. error: options-C bitcode-in-rlib=noand-C ltoare incompatible rust-lang/rust#71848 suggests using Cargo-specific environment variables to get correct behavior, as "Cargo has much more intrusive knowledge of LTO now for compile time speedups".Updated to glibc 2.32 in this PR, otherwise our Rust code doesn't build on aarch64 due to missing symbol versions. This will probably conflict with @tjkirch's version-bumps-in-progress, and I can cherry-pick his commit over here to replace mine to get rid of the conflict (I think).Looks like glibc updates need to be lockstep across the SDK and the OS.Testing done:
It builds, need to do a boot test.
CI will fail until I actually perform an SDK release.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.