Bump all the things #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
etungsten
approved these changes
Aug 7, 2020
Rust 1.45.0 added and enabled by default the `embed-bitcode` compiler flag, which includes LLVM bitcode into generated `rlib`s. For this reason, there's now only one location of Rust's LLVM libraries to strip.
|
The glibc bump here might be OK - the problems we'd see would be that the Go + Rust toolchains would have missing symbols, which would show up pretty quickly when building the OS. |
bcressey
approved these changes
Aug 8, 2020
|
Just saw the note in bottlerocket-os/bottlerocket#1014 - so let's back out the glibc update until I can figure out the best way to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
n/a
Description of changes:
libLLVM-*.sois no longer part ofrustlib; I believe this is related to the new on-by-defaultembed-bitcodecompiler flag in Rust 1.45Testing done:
Successfully builds Bottlerocket with some changes, which will go up on a draft PR on the OS repo.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.