Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper Update #1317

Merged
merged 9 commits into from
Oct 29, 2022
Merged

Wrapper Update #1317

merged 9 commits into from
Oct 29, 2022

Conversation

varunagrawal
Copy link
Collaborator

Update the wrapper to support Matlab properties and add a GTSAM test.

b37a1fec6 Merge pull request #154 from borglab/matlab/properties
93dec957a convert class properties to type parser.Variable so that the property collector functions are written correctly
d84e07f56 fix bug with proper closing of global functions
5a8505235 define setter and getter collector functions for cpp file
5067655e2 abstract out unwrap_argument and collector_return to their own functions
1ce29d71d add properties to properties block of .m file and add setters and getters
0c3e5573d write properties in class comment
9d85f7b6a disable superfluous pylint warnings
b45994d34 Merge pull request #152 from borglab/pybind-2.10
76ba199a2 upgrade pybind to 2.10
16e4e674b Merge pull request #150 from borglab/feature/parent_class_template
c7d1a466f Merge pull request #151 from borglab/fix/function_template_parameter_namespace
7278a309d retain namespace for template arguments
18ae5fb04 implement parent class allowed to have template parameters
fd4437899 unit tests for parent classes allowed to have template parameters

git-subtree-dir: wrap
git-subtree-split: b37a1fec689d6a42837a3bfb4dc947674e72be54
@varunagrawal varunagrawal added the matlab Related to MATLAB wrapper label Oct 28, 2022
@varunagrawal varunagrawal self-assigned this Oct 28, 2022
b3faf3fcd Merge pull request #155 from borglab/fix/matlab-properties
292b35440 fix python test
53053173e fix properties block bug in Matlab and add test to capture it

git-subtree-dir: wrap
git-subtree-split: b3faf3fcd1e805828decf67fc32814f104c3c1c2
ba3dcab16 Merge pull request #156 from borglab/fix/matlab-properties
feb4ee1b9 update docs
e57fec56b add unit test for templated class property

git-subtree-dir: wrap
git-subtree-split: ba3dcab16a8316634b56e3c4c6061531c91eb36c
Copy link

@mattking-smith mattking-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine and looks good.

@varunagrawal varunagrawal merged commit 719e4f9 into develop Oct 29, 2022
@varunagrawal varunagrawal deleted the wrap/update branch October 29, 2022 20:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
matlab Related to MATLAB wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants