fix default parameters in constructor of IncrementalFixedLagSmoother.h #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
reviewed
Oct 17, 2019
| @@ -114,6 +114,14 @@ class GTSAM_UNSTABLE_EXPORT IncrementalFixedLagSmoother: public FixedLagSmoother | |||
| const ISAM2Result& getISAM2Result() const{ return isamResult_; } | |||
|
|
|||
| protected: | |||
|
|
|||
| /* Create default parameters */ | |||
| ISAM2Params getDefaultParams() const { | |||
There was a problem hiding this comment.
Should be static, and renamed to `DefaultISAM2Params'
|
Added a comment, but PR seems to be closed? |
varunagrawal
added a commit
that referenced
this pull request
Oct 28, 2022
b37a1fec6 Merge pull request #154 from borglab/matlab/properties 93dec957a convert class properties to type parser.Variable so that the property collector functions are written correctly d84e07f56 fix bug with proper closing of global functions 5a8505235 define setter and getter collector functions for cpp file 5067655e2 abstract out unwrap_argument and collector_return to their own functions 1ce29d71d add properties to properties block of .m file and add setters and getters 0c3e5573d write properties in class comment 9d85f7b6a disable superfluous pylint warnings b45994d34 Merge pull request #152 from borglab/pybind-2.10 76ba199a2 upgrade pybind to 2.10 16e4e674b Merge pull request #150 from borglab/feature/parent_class_template c7d1a466f Merge pull request #151 from borglab/fix/function_template_parameter_namespace 7278a309d retain namespace for template arguments 18ae5fb04 implement parent class allowed to have template parameters fd4437899 unit tests for parent classes allowed to have template parameters git-subtree-dir: wrap git-subtree-split: b37a1fec689d6a42837a3bfb4dc947674e72be54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150
This change is