Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Precompiles): Throw fatal error if c-kzg is disabled #1589

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Jul 8, 2024

Throw a fatal error if kzg precompile is called without c-kzg feature enabled. This behaviour can always be overwritten with a handler builder.

Rename back InvalidEFOpcode to InvalidFEOpcode
There is 0xFE INVALID opcode ethereum/yellowpaper#230

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Valgrind Results:

==3931== Cachegrind, a cache and branch-prediction profiler
==3931== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3931== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3931== Command: target/release/snailtracer
==3931== 
--3931-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.843224837s
==3931== 
==3931== I   refs:      427,040,252
==3931== I1  misses:          3,191
==3931== LLi misses:          2,802
==3931== I1  miss rate:        0.00%
==3931== LLi miss rate:        0.00%
==3931== 
==3931== D   refs:      204,077,278  (132,268,918 rd   + 71,808,360 wr)
==3931== D1  misses:        341,461  (    201,454 rd   +    140,007 wr)
==3931== LLd misses:        137,814  (      4,492 rd   +    133,322 wr)
==3931== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3931== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3931== 
==3931== LL refs:           344,652  (    204,645 rd   +    140,007 wr)
==3931== LL misses:         140,616  (      7,294 rd   +    133,322 wr)
==3931== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit 81818a9 into main Jul 8, 2024
26 checks passed
@rakita rakita deleted the rakita/ckzg_fatal_error branch July 8, 2024 14:23
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant